The assembly files use directives that only work for ELF targets so skip
them when bootstrapping on MacOS.
Details
Details
- Reviewers
emaste imp bdrewery jhb - Commits
- rS338097: Allow bootstrapping libmd on MacOS
Diff Detail
Diff Detail
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 14850 Build 14964: arc lint + arc unit
Event Timeline
| lib/libmd/Makefile | ||
|---|---|---|
| 97 | I have heartburn about burring 'If I'm building on OS <blah>' deep into the build. | |
| lib/libmd/Makefile | ||
|---|---|---|
| 97 | I agree this is far from ideal but we need libmd for bootstrapping and I have no idea where else to add this check. | |
| lib/libmd/Makefile | ||
|---|---|---|
| 97 | Why not .if defined(BOOTSTRAPPING) then? forget about the .MAKE.OS. It's just an optimization anyway that has no material speedup at all and would cover all bases in a more general way. The comments could then change to "Don't build ASM sources when bootstrapping to avoid toolchain dependencies" or something equally generic. | |