[sockbuf] Don't access fields directly, use accessor functions
ClosedPublic
Actions

Authored by davide on Feb 8 2015, 10:24 PM.

Tags

None

Referenced Files

	F175295026: D1805.vs3695.id3698.diff
	Fri, Oct 9, 6:09 PM

	F175294844: D1805.id3695.diff
	Fri, Oct 9, 6:07 PM

	F175294789: D1805.vs3694.id3695.diff
	Fri, Oct 9, 6:06 PM

	Unknown Object (File)
	Fri, Oct 9, 4:50 PM

	Unknown Object (File)
	Fri, Oct 9, 8:42 AM

	Unknown Object (File)
	Fri, Oct 9, 6:17 AM

	Unknown Object (File)
	Fri, Oct 9, 6:03 AM

	Unknown Object (File)
	Fri, Oct 9, 2:27 AM

View All Files

Subscribers

emaste

freebsd-net-list

Details

Reviewers

kmacy
julian
np
rrs
lstewart
adrian
rwatson

Summary

Small step towards a saner sockbuf abstraction

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

davide updated this revision to Diff 3694.Feb 8 2015, 10:24 PM

davide updated this revision to Diff 3695.

davide retitled this revision from to [sockbuf] Don't access fields directly, use accessor functions.

davide updated this object.

davide edited the test plan for this revision. (Show Details)

davide added reviewers: kmacy, np, lstewart, rrs, rwatson.

davide set the repository for this revision to rS FreeBSD src repository - subversion.

davide added a subscriber: Unknown Object (MLST).

Updated removing the last place where this was used. I was not certain about it before so I previously left it as-is, but it looks like in this case order doesn't matter considering we're holding the socket buffer lock across the two calls.

emaste added a subscriber: emaste.Feb 9 2015, 1:53 AM

I plan to commit this in two days or such, so if there are objections, please raise them.

julian accepted this revision.Feb 11 2015, 8:01 AM

julian added a reviewer: julian.

This revision is now accepted and ready to land.Feb 11 2015, 8:01 AM

adrian accepted this revision.Feb 11 2015, 4:14 PM

adrian added a reviewer: adrian.

Seems sensible.

In HEAD now.

Revision Contents
Changeset List

Path

Size

sys/

kern/

uipc_socket.c

15 lines

Diff 3694

View Options

[sockbuf] Don't access fields directly, use accessor functionsClosedPublicActions