Page MenuHomeFreeBSD

[sockbuf] Don't access fields directly, use accessor functions
ClosedPublic

Authored by davide on Feb 8 2015, 10:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 23 2023, 6:37 AM
Unknown Object (File)
Dec 23 2023, 6:08 AM
Unknown Object (File)
Dec 22 2023, 9:30 PM
Unknown Object (File)
Dec 21 2023, 7:45 AM
Unknown Object (File)
Dec 5 2023, 2:38 PM
Unknown Object (File)
Nov 27 2023, 7:33 AM
Unknown Object (File)
Nov 22 2023, 8:28 AM
Unknown Object (File)
Nov 22 2023, 8:25 AM

Details

Summary

Small step towards a saner sockbuf abstraction

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

davide updated this revision to Diff 3695.
davide retitled this revision from to [sockbuf] Don't access fields directly, use accessor functions.
davide updated this object.
davide edited the test plan for this revision. (Show Details)
davide added reviewers: kmacy, np, lstewart, rrs, rwatson.
davide set the repository for this revision to rS FreeBSD src repository - subversion.
davide added a subscriber: Unknown Object (MLST).

Updated removing the last place where this was used. I was not certain about it before so I previously left it as-is, but it looks like in this case order doesn't matter considering we're holding the socket buffer lock across the two calls.

I plan to commit this in two days or such, so if there are objections, please raise them.

julian added a reviewer: julian.
This revision is now accepted and ready to land.Feb 11 2015, 8:01 AM
adrian added a reviewer: adrian.
rwatson edited edge metadata.

Seems sensible.