Install strings unconditionally
ClosedPublic
Actions

Authored by emaste on Oct 31 2016, 1:06 PM.

Details

Reviewers

des
bdrewery

Commits

rS326030: Install strings unconditionally

Summary

Previously it was enabled by WITH_/WITHOUT_TOOLCHAIN, but is commonly expected to be available and has some non-toolchain consumers (see PR 213665 for example).

strings is (now) taken from the ELF Tool Chain project and is BSD licensed so just install it unconditionally.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 21833.Oct 31 2016, 1:06 PM

emaste retitled this revision from to Install strings unconditionally.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: bdrewery, des.

emaste added inline comments.Oct 31 2016, 2:19 PM

lib/Makefile
45 ↗	(On Diff #21833)	note that libelftc is about a dozen small C files; compiling it unconditionally should be no problem

bdrewery accepted this revision.Oct 27 2017, 12:39 AM

bdrewery added inline comments.

lib/Makefile
138 ↗	(On Diff #21833)	whitespace

This revision is now accepted and ready to land.Oct 27 2017, 12:39 AM

emaste added inline comments.Nov 20 2017, 7:57 PM

lib/Makefile
138 ↗	(On Diff #21833)	This is just Phabricator misrendering; libpe is lined up under libdevdctl (as was libelftc previously)

Closed by commit rS326030: Install strings unconditionally (authored by emaste). · Explain WhyNov 20 2017, 8:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

lib/

Makefile

3 lines

usr.bin/

Makefile

2 lines

Diff 35503

View Options

head/lib/Makefile