Differential D9310

ixgbe(4): Update to 3.2.11-k
ClosedPublic
Actions

Authored by cramerj_intel.com on Jan 24 2017, 1:53 AM.

Tags

Referenced Files

	Unknown Object (File)
	Mon, Nov 25, 2:45 AM

	Unknown Object (File)
	Sun, Nov 24, 3:25 AM

	Unknown Object (File)
	Sat, Nov 23, 5:10 PM

	Unknown Object (File)
	Fri, Nov 22, 5:41 PM

	Unknown Object (File)
	Fri, Nov 22, 5:40 PM

	Unknown Object (File)
	Fri, Nov 22, 5:35 PM

	Unknown Object (File)
	Fri, Nov 22, 5:35 PM

	Unknown Object (File)
	Fri, Nov 22, 5:15 PM

Subscribers

jeffrey.e.pieper_intel.com

jim_netgate.com

Details

Reviewers

scottl
jeffrey.e.pieper_intel.com
gnn
sbruno
adrian
smh

Group Reviewers

Intel Networking

Commits

rS315333: ixgbe(4): Update to 3.2.11-k

Summary

Legacy ixgbe driver update, including:

Support for X553 (Denverton) devices.
Initialization code refactoring.
ixgbe-specific netmap code moved to ixgbe folder (but not removed from dev/netmap/).
VF driver full split. Some cleanup can be had due to redundant code, but this split goes inline with the refactoring.

NOTE: This is to be applied on the 10-STABLE tree (and not HEAD). The idea is that many of these changes will be ported to the iflib version of ixgbe. The legacy version residing in HEAD may or may not be updated at a later time. For HEAD, our focus will mainly be on the iflib driver.

Test Plan

Compile-tested with minimal touch-testing for the PF driver (none for VF). Respectfully request waiting for Jeff's team to perform a validation pass before committing.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6990
Build 7171: arc lint + arc unit

Event Timeline

cramerj_intel.com updated this revision to Diff 24359.Jan 24 2017, 1:53 AM

cramerj_intel.com retitled this revision from to ixgbe(4): Update to 3.2.11-k.

cramerj_intel.com updated this object.

cramerj_intel.com edited the test plan for this revision. (Show Details)

cramerj_intel.com added reviewers: Intel Networking, smh, scottl, gnn, adrian.

cramerj_intel.com set the repository for this revision to rS FreeBSD src repository - subversion.

cramerj_intel.com added a project: Intel Networking.

Herald added a reviewer: sbruno. · View Herald TranscriptJan 24 2017, 1:53 AM

Herald added a subscriber: imp. · View Herald Transcript

It looks like ixv fails to build on 10/stable:

/diskless/os/FreeBSD/10.3-STABLE_2017-01-24_D9310_ix-3.2.11-k/usr/src/sys/modules/ixv/../../dev/ixgbe/if_ixv.c:776:6: error: impl icit declaration of function 'ixgbe_setup_transmit_structures' is invalid in C99 [-Werror,-Wimplicit-function-declaration]

if (ixgbe_setup_transmit_structures(adapter)) {
    ^

all_subdir_ixgbe ---

ctfconvert -L VERSION -g ixgbe.o

all_subdir_ixlv ---
ixlvc.o ---
all_subdir_ixv ---

/diskless/os/FreeBSD/10.3-STABLE_2017-01-24_D9310_ix-3.2.11-k/usr/src/sys/modules/ixv/../../dev/ixgbe/if_ixv.c:776:6: note: did y ou mean 'ixv_setup_transmit_structures'?
/diskless/os/FreeBSD/10.3-STABLE_2017-01-24_D9310_ix-3.2.11-k/usr/src/sys/modules/ixv/../../dev/ixgbe/ixv.h:683:6: note: 'ixv_set up_transmit_structures' declared here
int ixv_setup_transmit_structures(struct adapter *);

all_subdir_isci ---
scic_sds_remote_node_context.o ---
all_subdir_ixv ---

1 error generated.

This revision now requires changes to proceed.Jan 24 2017, 3:38 PM

ixv_build_error.txt1018 BDownload

See attachment since Phabricator apparently didn't like the formatting of my paste...

Fixed compilation error for the VF driver.

Herald edited edge metadata. · View Herald TranscriptJan 24 2017, 5:44 PM

jeffrey.e.pieper_intel.com accepted this revision.Mar 3 2017, 3:31 PM

jeffrey.e.pieper_intel.com edited edge metadata.

This revision is now accepted and ready to land.Mar 3 2017, 3:31 PM

erj added a subscriber: erj.Mar 13 2017, 8:04 PM

erj edited the summary of this revision. (Show Details)Mar 15 2017, 9:19 PM

Closed by commit rS315333: ixgbe(4): Update to 3.2.11-k (authored by erj). · Explain WhyMar 17 2017, 12:48 PM

This revision was automatically updated to reflect the committed changes.

jim_netgate.com added a subscriber: jim_netgate.com.Apr 6 2017, 4:44 AM

Revision Contents
Changeset List

Path

Size

sys/

conf/

20 lines

dev/

ixgbe/

808 lines

154 lines

5211 lines

2054 lines

905 lines

1608 lines

903 lines

43 lines

45 lines

40 lines

76 lines

67 lines

242 lines

	ixgbe_bypass.h
	ixgbe_82598.h

76 lines

62 lines

934 lines

40 lines

50 lines

ixgbe_dcb_82598.h

40 lines

ixgbe_dcb_82598.c

40 lines

ixgbe_dcb_82599.h

40 lines

ixgbe_dcb_82599.c

40 lines

	ixgbe_fdir.h
	ixgbe_82598.h

84 lines

ixgbe_features.h

76 lines

47 lines

42 lines

	ixgbe_netmap.h
	ixgbe_82598.h

84 lines

487 lines

54 lines

95 lines

48 lines

417 lines

	ixgbe_rss.h
	ixgbe_82598.h

89 lines

103 lines

487 lines

41 lines

104 lines

65 lines

2382 lines

693 lines

	ixv_bypass.h
	ixgbe_82598.h

66 lines

	ixv_fdir.h
	ixgbe_82598.h

84 lines

76 lines

	ixv_mbx.h
	ixgbe_mbx.h

62 lines

	ixv_mbx.c
	ixgbe_mbx.c

177 lines

	ixv_netmap.h
	ixgbe_82598.h

84 lines

521 lines

	ixv_osdep.h
	ixgbe_osdep.h

129 lines

	ixv_osdep.c
	ixgbe_osdep.c

77 lines

	ixv_rss.h
	ixgbe_82598.h

89 lines

103 lines

	ixv_txrx.c
	ix_txrx.c

1643 lines

	ixv_type.h
	ixgbe_type.h

601 lines

	ixv_vf.h
	ixgbe_vf.h

151 lines

	ixv_vf.c
	ixgbe_vf.c

180 lines

modules/

ix/

5 lines

ixv/

6 lines

Diff 24392

sys/conf/files

Loading...

sys/dev/ixgbe/if_bypass.c

Loading...

sys/dev/ixgbe/if_fdir.c

Loading...

sys/dev/ixgbe/if_ix.c

Loading...

sys/dev/ixgbe/if_ixv.c

Loading...

sys/dev/ixgbe/if_sriov.c

Loading...

sys/dev/ixgbe/ix_txrx.c

Loading...

sys/dev/ixgbe/ixgbe.h

Loading...

sys/dev/ixgbe/ixgbe_82598.h

Loading...

sys/dev/ixgbe/ixgbe_82598.c

Loading...

sys/dev/ixgbe/ixgbe_82599.h

Loading...

sys/dev/ixgbe/ixgbe_82599.c

Loading...

sys/dev/ixgbe/ixgbe_api.h

Loading...

sys/dev/ixgbe/ixgbe_api.c

Loading...

sys/dev/ixgbe/ixgbe_bypass.h

Loading...

sys/dev/ixgbe/ixgbe_common.h

Loading...

sys/dev/ixgbe/ixgbe_common.c

Loading...

sys/dev/ixgbe/ixgbe_dcb.h

Loading...

sys/dev/ixgbe/ixgbe_dcb.c

Loading...

sys/dev/ixgbe/ixgbe_dcb_82598.h

Loading...

sys/dev/ixgbe/ixgbe_dcb_82598.c

Loading...

sys/dev/ixgbe/ixgbe_dcb_82599.h

Loading...

sys/dev/ixgbe/ixgbe_dcb_82599.c

Loading...

sys/dev/ixgbe/ixgbe_fdir.h

Loading...

sys/dev/ixgbe/ixgbe_features.h

Loading...

sys/dev/ixgbe/ixgbe_mbx.h

Loading...

sys/dev/ixgbe/ixgbe_mbx.c

Loading...

sys/dev/ixgbe/ixgbe_netmap.h

Loading...

sys/dev/ixgbe/ixgbe_netmap.c

Loading...

sys/dev/ixgbe/ixgbe_osdep.h

Loading...

sys/dev/ixgbe/ixgbe_osdep.c

Loading...

sys/dev/ixgbe/ixgbe_phy.h

Loading...

sys/dev/ixgbe/ixgbe_phy.c

Loading...

sys/dev/ixgbe/ixgbe_rss.h

Loading...

sys/dev/ixgbe/ixgbe_sriov.h

Loading...

sys/dev/ixgbe/ixgbe_type.h

Loading...

sys/dev/ixgbe/ixgbe_vf.h

Loading...

sys/dev/ixgbe/ixgbe_vf.c

Loading...

sys/dev/ixgbe/ixgbe_x540.h

Loading...

sys/dev/ixgbe/ixgbe_x540.c

Loading...

sys/dev/ixgbe/ixgbe_x550.h

Loading...

sys/dev/ixgbe/ixgbe_x550.c

Loading...

sys/dev/ixgbe/ixv.h

Loading...

sys/dev/ixgbe/ixv_bypass.h

Loading...

sys/dev/ixgbe/ixv_fdir.h

Loading...

sys/dev/ixgbe/ixv_features.h

Loading...

sys/dev/ixgbe/ixv_mbx.h

Loading...

sys/dev/ixgbe/ixv_mbx.c

Loading...

sys/dev/ixgbe/ixv_netmap.h

Loading...

sys/dev/ixgbe/ixv_netmap.c

Loading...

sys/dev/ixgbe/ixv_osdep.h

Loading...

sys/dev/ixgbe/ixv_osdep.c

Loading...

sys/dev/ixgbe/ixv_rss.h

Loading...

sys/dev/ixgbe/ixv_sriov.h

Loading...

sys/dev/ixgbe/ixv_txrx.c

Loading...

sys/dev/ixgbe/ixv_type.h

Loading...

sys/dev/ixgbe/ixv_vf.h

Loading...

sys/dev/ixgbe/ixv_vf.c

Loading...

sys/modules/ix/Makefile

Loading...

sys/modules/ixv/Makefile

Loading...