Page MenuHomeFreeBSD

ixgbe(4): Update to 3.2.11-k
ClosedPublic

Authored by cramerj_intel.com on Jan 24 2017, 1:53 AM.
Referenced Files
Unknown Object (File)
Thu, Mar 21, 8:02 PM
Unknown Object (File)
Jan 13 2024, 4:31 AM
Unknown Object (File)
Dec 22 2023, 9:50 PM
Unknown Object (File)
Dec 19 2023, 10:44 PM
Unknown Object (File)
Dec 14 2023, 2:39 AM
Unknown Object (File)
Dec 7 2023, 5:56 AM
Unknown Object (File)
Dec 3 2023, 11:26 AM
Unknown Object (File)
Nov 25 2023, 1:11 PM

Details

Summary

Legacy ixgbe driver update, including:

  1. Support for X553 (Denverton) devices.
  2. Initialization code refactoring.
  3. ixgbe-specific netmap code moved to ixgbe folder (but not removed from dev/netmap/).
  4. VF driver full split. Some cleanup can be had due to redundant code, but this split goes inline with the refactoring.

NOTE: This is to be applied on the 10-STABLE tree (and not HEAD). The idea is that many of these changes will be ported to the iflib version of ixgbe. The legacy version residing in HEAD may or may not be updated at a later time. For HEAD, our focus will mainly be on the iflib driver.

Test Plan

Compile-tested with minimal touch-testing for the PF driver (none for VF). Respectfully request waiting for Jeff's team to perform a validation pass before committing.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cramerj_intel.com retitled this revision from to ixgbe(4): Update to 3.2.11-k.
cramerj_intel.com updated this object.
cramerj_intel.com edited the test plan for this revision. (Show Details)
cramerj_intel.com set the repository for this revision to rS FreeBSD src repository - subversion.

It looks like ixv fails to build on 10/stable:

/diskless/os/FreeBSD/10.3-STABLE_2017-01-24_D9310_ix-3.2.11-k/usr/src/sys/modules/ixv/../../dev/ixgbe/if_ixv.c:776:6: error: impl icit declaration of function 'ixgbe_setup_transmit_structures' is invalid in C99 [-Werror,-Wimplicit-function-declaration]

if (ixgbe_setup_transmit_structures(adapter)) {
    ^
  • all_subdir_ixgbe ---

ctfconvert -L VERSION -g ixgbe.o

  • all_subdir_ixlv ---
  • ixlvc.o ---
  • all_subdir_ixv ---

/diskless/os/FreeBSD/10.3-STABLE_2017-01-24_D9310_ix-3.2.11-k/usr/src/sys/modules/ixv/../../dev/ixgbe/if_ixv.c:776:6: note: did y ou mean 'ixv_setup_transmit_structures'?
/diskless/os/FreeBSD/10.3-STABLE_2017-01-24_D9310_ix-3.2.11-k/usr/src/sys/modules/ixv/../../dev/ixgbe/ixv.h:683:6: note: 'ixv_set up_transmit_structures' declared here
int ixv_setup_transmit_structures(struct adapter *);

^
  • all_subdir_isci ---
  • scic_sds_remote_node_context.o ---
  • all_subdir_ixv ---

1 error generated.

This revision now requires changes to proceed.Jan 24 2017, 3:38 PM

See attachment since Phabricator apparently didn't like the formatting of my paste...

cramerj_intel.com edited edge metadata.
  • Fixed compilation error for the VF driver.
This revision is now accepted and ready to land.Mar 3 2017, 3:31 PM
This revision was automatically updated to reflect the committed changes.