Add SSP SPI driver for Intel Baytrail SoC
ClosedPublic
Actions

Authored by gonzo on Dec 23 2016, 11:05 PM.

Details

Reviewers

manu
imp
br

Commits

rS314363: MFC r310645:
rS310645: [intelspi] Add SPI driver for Intel BayTrail SoC

Summary

Add SPI driver for multi-functional serial port (SSP) that can
be found in Intel's SoCs. I only have Baytrail SoC so this is the only
supported hardware for now.

Test Plan

Use SSD1306 for basic tests

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6371
Build 6609: arc lint + arc unit

Event Timeline

gonzo updated this revision to Diff 23229.Dec 23 2016, 11:05 PM

gonzo retitled this revision from to Add SSP SPI driver for Intel Baytrail SoC.

gonzo updated this object.

gonzo edited the test plan for this revision. (Show Details)

gonzo added reviewers: manu, imp, br.

looks good

sys/dev/intel/spi.c
79	we usually do #define<tab>INTELSPI_SSPREG_SSCR0 #define<tab><space>SSCR0_SCR(n) instead of #define<tab>INTELSPI_SSPREG_SSCR0 #define<tab><tab>SSCR0_SCR(n)
156	if (sssr & SSSR_TNF) return (0); return (1);
385	remove empty line here

This revision is now accepted and ready to land.Dec 24 2016, 9:32 PM

Wouldn't be better to directly add support for mode/clock setting in transfer ?

In D8896#184336, @manu wrote:

Wouldn't be better to directly add support for mode/clock setting in transfer ?

Yes. I'll probably do this before committing the driver

Closed by commit rS310645: [intelspi] Add SPI driver for Intel BayTrail SoC (authored by gonzo). · Explain WhyDec 27 2016, 10:37 PM

This revision was automatically updated to reflect the committed changes.

In D8896#184406, @gonzo wrote:

In D8896#184336, @manu wrote:

Wouldn't be better to directly add support for mode/clock setting in transfer ?

Yes. I'll probably do this before committing the driver