Page MenuHomeFreeBSD

install header files required development with libzfs_core
ClosedPublic

Authored by avg on Sep 22 2016, 12:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 17, 8:02 PM
Unknown Object (File)
Wed, Nov 12, 6:43 PM
Unknown Object (File)
Thu, Nov 6, 5:31 AM
Unknown Object (File)
Sat, Nov 1, 5:23 PM
Unknown Object (File)
Sun, Oct 26, 1:25 AM
Unknown Object (File)
Thu, Oct 23, 3:35 AM
Unknown Object (File)
Wed, Oct 22, 7:38 PM
Unknown Object (File)
Wed, Oct 22, 7:38 PM
Subscribers

Details

Summary

libzfs_core provides a rather limited but committed (stable) interface
for working with ZFS. We install libzfs_core shared library but we do
not install header files required for developing programs that use
the library. This change is to install the required header files
libzfs_core.h, libnvpair.h and sys/nvpair.h.

As this is the first time I am touching include/Makefile, I am not sure
if my change is correct.

In this change I suggest installing the headers into the same locations
as on illumos.

Another alternative is to follow what ZoL does and install the headers
under /usr/include/libzfs directory.
Yet another possibility is to install libnvpair.h and sys/nvpair into
a directory like /usr/include/illumos, because those headers are not
specific to ZFS. libzfs_core.h could be installed either at the top
level or under libzfs/ directory.

Diff Detail

Event Timeline

avg retitled this revision from to install header files required development with libzfs_core.
avg updated this object.
avg edited the test plan for this revision. (Show Details)
avg added reviewers: mav, smh, will, bdrewery, sjg, ngie, gjb.
mav edited edge metadata.

Makefiles are not my area either, but general motivation looks good to me. I think that following original illumos layout is a good way to go, while inventing custom one (/illumos) would be the worst.

This revision is now accepted and ready to land.Oct 5 2016, 1:32 AM
markj added a reviewer: markj.
markj added a subscriber: markj.

Seems ok to me. I've been meaning to do something similar for dtrace/CTF headers.

This revision was automatically updated to reflect the committed changes.