Each watchdog pass submitted an Abort for every timed-out command
with nothing counting them against the controller's ACL. A
controller may complete excess Aborts with Abort Command Limit
Exceeded status.
Details
Details
- Reviewers
imp adrian - Commits
- rGc91485376bb0: nvme: enforce the Abort Command Limit
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
reset needs to zero this, no?
| sys/dev/nvme/nvme_qpair.c | ||
|---|---|---|
| 988 | Since this isn't the only place we reset the controller, don't we need to directly zero this in the reset path? | |
| sys/dev/nvme/nvme_qpair.c | ||
|---|---|---|
| 988 | If the reset path completes outstanding Abort requests, their callbacks will dec the counter after we’ve already cleared it. | |