Page MenuHomeFreeBSD
Differential D60685

ipfw: cleanup SYSINIT(9)s
ClosedPublic
Actions

Authored by glebius on Mon, Oct 12, 7:50 PM.
Tags
None
Referenced Files
F176167187: D60685.diff
Fri, Oct 16, 3:14 PM
Unknown Object (File)
Thu, Oct 15, 7:24 AM
Unknown Object (File)
Wed, Oct 14, 4:56 PM
Unknown Object (File)
Tue, Oct 13, 6:49 PM
Unknown Object (File)
Tue, Oct 13, 3:19 PM
Unknown Object (File)
Tue, Oct 13, 3:10 PM
Unknown Object (File)
Tue, Oct 13, 2:37 PM
Unknown Object (File)
Tue, Oct 13, 12:56 PM
View All 14 Files
Subscribers
donner
imp
melifaro
pouria
vegeta_tuxpowered.net

Details

Reviewers
ae
lytboris_gmail.com
Group Reviewers
network
Commits
rG9bcc1e97dda8: ipfw: cleanup SYSINIT(9)s
Summary

Make them all belong to SI_SUB_PROTO_FIREWALL and explicitly specify
order. Prefer SYSINIT() over modevent, for those subsystems that don't
have dependencies. All subsystems just depend on the main module and they
don't depend on each other, except dummynet which also has submodules.
Thus, keep DECLARE_MODULE() only for the main module and dummynet.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 78105
Build 74988: arc lint + arc unit

Event Timeline

glebius created this revision.Mon, Oct 12, 7:50 PM
Herald added subscribers: vegeta_tuxpowered.net, donner, melifaro, imp. · View Herald TranscriptMon, Oct 12, 7:50 PM
glebius requested review of this revision.Mon, Oct 12, 7:50 PM
Harbormaster completed remote builds in B78105: Diff 189672.Mon, Oct 12, 7:50 PM
glebius added a reviewer: lytboris_gmail.com.Mon, Oct 12, 7:50 PM
pouria added a subscriber: pouria.Tue, Oct 13, 10:02 AM

I'm not expert enough to approve, but this LGTM.

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Oct 16, 9:17 PM
Closed by commit rG9bcc1e97dda8: ipfw: cleanup SYSINIT(9)s (authored by glebius). · Explain Why
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rG9bcc1e97dda8: ipfw: cleanup SYSINIT(9)s.

Revision Contents
Changeset List

PathSize
sys/
netpfil/
ipfw/
2 lines
10 lines
60 lines
9 lines
44 lines
nat64/
36 lines
nptv6/
18 lines

Diff 189672

View Options

sys/netpfil/ipfw/dn_sched.h

Loading...
View Options

sys/netpfil/ipfw/ip_dummynet.c

Loading...
View Options

sys/netpfil/ipfw/ip_fw2.c

Loading...
View Options

sys/netpfil/ipfw/ip_fw_compat.c

Loading...
View Options

sys/netpfil/ipfw/ip_fw_nat.c

Loading...
View Options

sys/netpfil/ipfw/nat64/ip_fw_nat64.c

Loading...
View Options

sys/netpfil/ipfw/nptv6/ip_fw_nptv6.c

Loading...