x11/bhotkeys-airplane: New port
ClosedPublic
Actions

Authored by dteske on Thu, Oct 8, 5:02 AM.

Details

Reviewers

jrm
fuz
adrian
emaste

Commits

R11:294ed5056de0: x11/bhotkeys-airplane: New port

Summary

Fn airplane-mode and rfkill hotkeys for bhotkeys.
airplane-radiosd holds the radios for the session.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77963
Build 74846: arc lint + arc unit

Event Timeline

dteske requested review of this revision.Thu, Oct 8, 5:02 AM

dteske created this revision.

Harbormaster completed remote builds in B77834: Diff 189021.Thu, Oct 8, 5:02 AM

dteske added a parent revision: D60456: x11/bhotkeys: New port.Thu, Oct 8, 5:10 AM

Rebase over bhotkeys

Harbormaster completed remote builds in B77837: Diff 189024.Thu, Oct 8, 5:13 AM

LGTM and approved for commit.

This revision is now accepted and ready to land.Thu, Oct 8, 9:21 PM

I took a peek at the upstread code and noticed that the RC script does pw groupadd "$airplane_radiosd_group". It would be better if the port did this. See https://docs.freebsd.org/en/books/porters-handbook/book/#users-and-groups.

Same optional nit as in D60456 about the subject in the commit message.

dteske retitled this revision from x11/bhotkeys-airplane: new port to x11/bhotkeys-airplane: New port.Fri, Oct 9, 2:38 AM

Create group (airplane_radiosd:403) as part of package install

Update port to upstream 1.2 which drops group creation
and also fixes service typo in airplane-radiosd(8)

This revision now requires review to proceed.Sat, Oct 10, 3:30 PM

Harbormaster completed remote builds in B77963: Diff 189366.Sat, Oct 10, 3:30 PM

One thing I missed last time: You also want USE_RC_SUBR as you did in x11/framework-autorotate.

Ref: https://docs.freebsd.org/en/books/porters-handbook/book/#rc-scripts.

In D60457#1389268, @jrm wrote:

One thing I missed last time: You also want USE_RC_SUBR as you did in x11/framework-autorotate.

Ref: https://docs.freebsd.org/en/books/porters-handbook/book/#rc-scripts.

That's only for when the software doesn't ship its own rc.d script. bhotkeys-airplane has its own and also respects DESTDIR and PREFIX, so USE_RC_SUBR is not applicable. Porter's handbook on USE_RC_SUBR:

Scripts must be placed in the files subdirectory and a .in suffix must be added to their filename.

In the case of x11/framework-autorotate there is a files/framework_autorotate.in file to satisfy USE_RC_SUBR. However, in the case of this port, adding it causes a build error on missing file