Page MenuHomeFreeBSD

libnvmf: Improve handling of the CATTR field in CONNECT commands
Needs ReviewPublic

Authored by jhb on Thu, Oct 8, 3:38 PM.
Tags
None
Referenced Files
F176503142: D60469.diff
Mon, Oct 19, 9:18 AM
F176445419: D60469.id189258.diff
Sun, Oct 18, 10:46 PM
F176445413: D60469.id189450.diff
Sun, Oct 18, 10:46 PM
F176445385: D60469.id189060.diff
Sun, Oct 18, 10:46 PM
Unknown Object (File)
Sun, Oct 18, 8:30 PM
Unknown Object (File)
Fri, Oct 16, 11:58 PM
Unknown Object (File)
Fri, Oct 16, 7:05 PM
Unknown Object (File)
Fri, Oct 16, 5:03 PM
Subscribers
None

Details

Reviewers
imp
Group Reviewers
cam
Summary
  • Add an association option to permit advertising support for I/O queue deletion in CATTR from the host side.
  • When validating CONNECT commands in nvmf_accept(), validate the CATTR field rejecting non-zero values in reserved fields.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77911
Build 74794: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Thu, Oct 8, 3:38 PM
jhb created this revision.

Neither the host nor controller sides in our NVMeoF bits support deleting individual I/O queues, so adding the new parameter is cosmetic (But needed if we ever had a compelling use case. I should probably implement support for it on the controller/target side at some point, but would need to be able to test it). However, validating that reserved fields aren't set is useful. I guess I can actually add some tests based on some recent tests I've started writing for nvmft at least, so I'll probably defer merging this until I can add some tests.

Add tests for invalid connect attributes