Page MenuHomeFreeBSD
Differential D60090

arm64/pmap: Add support for FEAT_TTL
Needs ReviewPublic
Actions

Authored by sarah.walker2_arm.com on Mon, Sep 28, 11:03 AM.
Tags
None
Referenced Files
F176475921: D60090.id189584.diff
Mon, Oct 19, 4:15 AM
Unknown Object (File)
Sun, Oct 18, 1:41 AM
Unknown Object (File)
Sat, Oct 17, 4:45 PM
Unknown Object (File)
Sat, Oct 17, 4:44 PM
Unknown Object (File)
Sat, Oct 17, 8:11 AM
Unknown Object (File)
Thu, Oct 15, 4:53 PM
Unknown Object (File)
Wed, Oct 14, 8:29 AM
Unknown Object (File)
Tue, Oct 13, 6:20 PM
View All 49 Files
Subscribers
emaste
imp

Details

Reviewers
andrew
manu
alc
markj
kib
Summary

FEAT_TTL adds a Translation Table Level field for TLB maintenance intructions,
to indicate the level holding the leaf address for the address being
invalidated. This can reduce the cost of TLB invalidation.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77851
Build 74734: arc lint + arc unit

Event Timeline

sarah.walker2_arm.com created this revision.Mon, Sep 28, 11:03 AM
Herald added a reviewer: andrew. · View Herald TranscriptMon, Sep 28, 11:03 AM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added subscribers: emaste, imp. · View Herald Transcript
Harbormaster completed remote builds in B77409: Diff 187869.Mon, Sep 28, 11:03 AM
sarah.walker2_arm.com requested review of this revision.Mon, Sep 28, 11:03 AM
andrew added a comment.Tue, Sep 29, 9:54 AM

I think these TLBI_TTL_UNKNOWN values can specify the level, but it would be useful for someone else to check

sys/arm64/arm64/pmap.c
3021

TLBI_TTL_L3?

3720

TLBI_TTL_L3?

4764

TLBI_TTL_L3?

6018

TLBI_TTL_L3?

6037

TLBI_TTL_L3?

6108

TLBI_TTL_L3?

8442

TLBI_TTL_L3?

8937

TLBI_TTL_L3?

andrew added reviewers: alc, markj, kib.Tue, Sep 29, 10:01 AM
alc added inline comments.Wed, Sep 30, 4:04 PM
sys/arm64/arm64/pmap.c
3021

No, not this one. (This function is misnamed. It's suffix should be _ptp, not _l3.)

8108

TLBI_TTL_L2

sarah.walker2_arm.com updated this revision to Diff 189058.Thu, Oct 8, 3:31 PM

Address review comments and rebase

Harbormaster completed remote builds in B77851: Diff 189058.Thu, Oct 8, 3:31 PM
andrew accepted this revision.Thu, Oct 8, 3:52 PM
This revision is now accepted and ready to land.Thu, Oct 8, 3:52 PM
alc added inline comments.Sat, Oct 10, 4:02 PM
sys/arm64/arm64/pmap.c
460–473

I didn't see a reason for this change.

464–472

Aren't these backwards? They evaluate to a non-zero value when ttl is UNKNOWN.

2164

The prevailing style is simply if (pmap_ttl_support).

sarah.walker2_arm.com updated this revision to Diff 189584.Mon, Oct 12, 10:41 AM

Address review comments

This revision now requires review to proceed.Mon, Oct 12, 10:41 AM
Harbormaster completed remote builds in B78056: Diff 189584.Mon, Oct 12, 10:41 AM

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
130 lines

Diff 189058

View Options

sys/arm64/arm64/pmap.c

Loading...