Page MenuHomeFreeBSD
Differential D59015

pf: Fix fallout from the STATE_LOOKUP macro removal
ClosedPublic
Actions

Authored by markj on Aug 19 2026, 10:00 PM.
Tags
None
Referenced Files
F174539819: D59015.id185217.diff
Sun, Oct 4, 1:02 AM
F174458616: D59015.id185217.diff
Sat, Oct 3, 10:10 AM
F174458608: D59015.id185217.diff
Sat, Oct 3, 10:10 AM
Unknown Object (File)
Fri, Oct 2, 8:20 PM
Unknown Object (File)
Fri, Oct 2, 12:03 PM
Unknown Object (File)
Fri, Oct 2, 12:03 PM
Unknown Object (File)
Thu, Oct 1, 9:54 PM
Unknown Object (File)
Thu, Oct 1, 9:19 PM
View All 76 Files
Subscribers
farrokhi
glebius
imp
melifaro
vegeta_tuxpowered.net

Details

Reviewers
kp
Commits
rG971d24f203dd: pf: Fix fallout from the STATE_LOOKUP macro removal
rG00a793def743: pf: Fix fallout from the STATE_LOOKUP macro removal
Summary

Commit 8572367b6814 ("pf: remove STATE_LOOKUP") introduced two seemingly
unintentional changes with respect to divert(4)-injected packets (i.e.,
the PACKET_LOOPED case): we no longer return the matching state, and
direct callers of pf_find_state() now treat matches of diverted packets
the same as having no matching state at all.

This seems inadvertent, and breaks certain rulesets which use divert-to.
Fix them, and add a regression test case.

Fixes: 8572367b6814 ("pf: remove STATE_LOOKUP")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75773
Build 72656: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
netpfil/
pf/
17 lines
tests/
sys/
netpfil/
pf/
82 lines

Diff 184412

View Options

sys/netpfil/pf/pf.c

Loading...
View Options

tests/sys/netpfil/pf/route_to.sh

Loading...