Page MenuHomeFreeBSD
Differential D58982

nanobsd: Add an optional CIDATA partition
Needs ReviewPublic
Actions

Authored by senguptaangshuman17_gmail.com on Wed, Aug 19, 10:33 AM.
Tags
None
Referenced Files
F169953308: D58982.id184543.diff
Thu, Sep 3, 2:20 AM
F169934623: D58982.id185014.diff
Thu, Sep 3, 12:44 AM
F169930008: D58982.id184576.diff
Thu, Sep 3, 12:22 AM
F169928647: D58982.id185118.diff
Thu, Sep 3, 12:15 AM
F169922005: D58982.id185278.diff
Wed, Sep 2, 11:43 PM
F169894685: D58982.id184850.diff
Wed, Sep 2, 9:56 PM
F169872490: D58982.id184755.diff
Wed, Sep 2, 8:41 PM
F169807806: D58982.id.diff
Wed, Sep 2, 3:19 PM
View All Files
Subscribers
imp

Details

Reviewers
jlduran
jrm
ashish
Summary

To be used when provisioning via nuageinit.

Nuageinit still needs to understand read-only root filesystems and
persist the changes to /cfg.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75735
Build 72618: arc lint + arc unit

Event Timeline

senguptaangshuman17_gmail.com created this revision.Wed, Aug 19, 10:33 AM
Herald added a subscriber: imp. · View Herald TranscriptWed, Aug 19, 10:33 AM
senguptaangshuman17_gmail.com requested review of this revision.Wed, Aug 19, 10:33 AM
Harbormaster completed remote builds in B75735: Diff 184349.Wed, Aug 19, 10:33 AM
senguptaangshuman17_gmail.com added a parent revision: D58981: nanobsd: Allow custom alignment boundaries.Wed, Aug 19, 10:34 AM
senguptaangshuman17_gmail.com updated this revision to Diff 184482.Thu, Aug 20, 10:13 AM
Harbormaster completed remote builds in B75816: Diff 184482.Thu, Aug 20, 10:13 AM
senguptaangshuman17_gmail.com updated this revision to Diff 184533.Thu, Aug 20, 12:25 PM
Harbormaster completed remote builds in B75862: Diff 184533.Thu, Aug 20, 12:25 PM
senguptaangshuman17_gmail.com updated this revision to Diff 184543.Thu, Aug 20, 2:12 PM
Harbormaster completed remote builds in B75869: Diff 184543.Thu, Aug 20, 2:12 PM
senguptaangshuman17_gmail.com edited parent revisions, added: D58980: nanobsd: Do not ship with a FreeBSD-local directory; removed: D58981: nanobsd: Allow custom alignment boundaries.Thu, Aug 20, 2:13 PM
senguptaangshuman17_gmail.com updated this revision to Diff 184549.Thu, Aug 20, 2:27 PM
Harbormaster completed remote builds in B75874: Diff 184549.Thu, Aug 20, 2:27 PM
senguptaangshuman17_gmail.com updated this revision to Diff 184576.Thu, Aug 20, 3:13 PM
Harbormaster completed remote builds in B75899: Diff 184576.Thu, Aug 20, 3:13 PM
senguptaangshuman17_gmail.com updated this revision to Diff 184606.Thu, Aug 20, 7:04 PM

Address review comments: clarify nanobsd.sh is_defined() comment

Herald added a reviewer: scheduler. · View Herald TranscriptThu, Aug 20, 7:04 PM
Harbormaster completed remote builds in B75920: Diff 184606.Thu, Aug 20, 7:04 PM
lwhsu removed a reviewer: scheduler.Thu, Aug 20, 8:17 PM
senguptaangshuman17_gmail.com updated this revision to Diff 184755.Sat, Aug 22, 10:32 PM

Clean up merge conflict markers in defaults.sh

Harbormaster completed remote builds in B75973: Diff 184755.Sat, Aug 22, 10:32 PM
imp added a comment.Sat, Aug 22, 10:45 PM

Why FAT?

tools/tools/nanobsd/gpt.sh
78

Why FAT?

senguptaangshuman17_gmail.com edited parent revisions, added: D58978: nanobsd: Handle the data partition in fstab; removed: D58980: nanobsd: Do not ship with a FreeBSD-local directory.Sun, Aug 23, 8:22 PM
senguptaangshuman17_gmail.com added a comment.Sun, Aug 23, 10:13 PM
In D58982#1355684, @imp wrote:

Why FAT?

As per my knowledge, nuageinit(7) manpage accepts either msdosfs (FAT) or cd9660 (ISO9660).
For why FAT was chosen over ISO9660, I need @jlduran's views on this.

senguptaangshuman17_gmail.com updated this revision to Diff 184850.Sun, Aug 23, 11:04 PM
Harbormaster completed remote builds in B76036: Diff 184850.Sun, Aug 23, 11:04 PM
jlduran added a comment.Mon, Aug 24, 1:24 PM
In D58982#1356214, @senguptaangshuman17_gmail.com wrote:
In D58982#1355684, @imp wrote:

Why FAT?

As per my knowledge, nuageinit(7) manpage accepts either msdosfs (FAT) or cd9660 (ISO9660).
For why FAT was chosen over ISO9660, I need @jlduran's views on this.

I have no preference of one over the other. iso9660 sounds like a nice fit since it is inherently read-only; however, msdos is easier to provision. The idea was to replicate what Raspberry Pi images do: the user inserts the SD card into their PC, and it gets mounted as a FAT device that they can modify and easily provision.

tools/tools/nanobsd/customizations.sh
142

This change seems unrelated.

tools/tools/nanobsd/defaults.sh
162

This change seems unrelated.

1562

This change seems unrelated.

tools/tools/nanobsd/gpt.sh
290–291

Why remove this comment?

363

This change seems unrelated.

366

This change seems unrelated.

379

This change seems unrelated.

387

This change seems unrelated.
I think some of these changes should be squashed with D58964.

tools/tools/nanobsd/nanobsd.sh
38 ↗(On Diff #184850)

This comment seems unrelated.

senguptaangshuman17_gmail.com edited parent revisions, added: D58974: nanobsd: Refactor cust_pkgng; removed: D58978: nanobsd: Handle the data partition in fstab.Tue, Aug 25, 6:07 AM
senguptaangshuman17_gmail.com updated this revision to Diff 184949.Tue, Aug 25, 6:09 AM
Harbormaster completed remote builds in B76072: Diff 184949.Tue, Aug 25, 6:09 AM
senguptaangshuman17_gmail.com updated this revision to Diff 185014.Tue, Aug 25, 8:01 AM

Rebase stack on top of D59043 update

Harbormaster completed remote builds in B76137: Diff 185014.Tue, Aug 25, 8:01 AM
senguptaangshuman17_gmail.com updated this revision to Diff 185118.Tue, Aug 25, 9:02 PM
Harbormaster completed remote builds in B76177: Diff 185118.Tue, Aug 25, 9:02 PM
senguptaangshuman17_gmail.com updated this revision to Diff 185278.Thu, Aug 27, 9:36 PM
Harbormaster completed remote builds in B76268: Diff 185278.Thu, Aug 27, 9:36 PM
senguptaangshuman17_gmail.com added a child revision: D59232: nanobsd: Use fixed standard MS-DOS labels for EFI/CIDATA.Thu, Aug 27, 9:37 PM
jlduran mentioned this in D59232: nanobsd: Use fixed standard MS-DOS labels for EFI/CIDATA.Fri, Aug 28, 1:05 PM
senguptaangshuman17_gmail.com updated this revision to Diff 185398.Sat, Aug 29, 9:31 AM
Harbormaster completed remote builds in B76313: Diff 185398.Sat, Aug 29, 9:31 AM

Revision Contents
Changeset List

PathSize
tools/
tools/
nanobsd/
7 lines
5 lines
81 lines

Diff 184349

View Options

tools/tools/nanobsd/customizations.sh

Loading...
View Options

tools/tools/nanobsd/defaults.sh

Loading...
View Options

tools/tools/nanobsd/gpt.sh

Loading...