Page MenuHomeFreeBSD
Differential D58459

unix: factor `unp_sun_path()` out of bind and connect
AcceptedPublic
Actions

Authored by inquire_JohnEricson.me on Sat, Jul 25, 8:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Aug 6, 11:31 AM
Unknown Object (File)
Wed, Aug 5, 5:18 PM
Unknown Object (File)
Wed, Aug 5, 7:38 AM
Unknown Object (File)
Tue, Aug 4, 6:23 PM
Unknown Object (File)
Mon, Aug 3, 8:13 PM
Unknown Object (File)
Mon, Aug 3, 7:47 PM
Unknown Object (File)
Mon, Aug 3, 7:21 PM
Unknown Object (File)
Mon, Aug 3, 7:03 PM
View All 22 Files
Subscribers
glebius
imp
olce

Details

Reviewers
markj
kib
Summary

Extract the AF_UNIX validation plus sun_path/length lookup shared by
uipc_bindat(), unp_connect(), and unp_connectat() into a helper that
hands back the path pointer and its length. Each caller keeps its own
empty-path policy and, where needed, its own copy of the path.

Signed-off-by: John Ericson <John.Ericson@Obsidian.Systems>
Assisted-by: Claude Code (Claude Opus 4.8 and Fable 5)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 75132
Build 72015: arc lint + arc unit

Event Timeline

inquire_JohnEricson.me created this revision.Sat, Jul 25, 8:21 PM
Herald added subscribers: olce, glebius, imp. · View Herald TranscriptSat, Jul 25, 8:21 PM
inquire_JohnEricson.me requested review of this revision.Sat, Jul 25, 8:21 PM
Harbormaster completed remote builds in B75132: Diff 182707.Sat, Jul 25, 8:21 PM
inquire_JohnEricson.me added a parent revision: D58404: unix: split `unp_connectat()` in two.Sat, Jul 25, 8:21 PM
inquire_JohnEricson.me added a child revision: D58460: unix: pin the pathname peer by reference across the connect.
markj accepted this revision.Tue, Jul 28, 10:37 PM
markj added inline comments.
sys/kern/uipc_usrreq.c
610

FreeBSD style puts parents around all return values.

This revision is now accepted and ready to land.Tue, Jul 28, 10:37 PM
inquire_JohnEricson.me updated this revision to Diff 183190.Fri, Jul 31, 11:36 PM

Fix the return statement to match the style guide

This revision now requires review to proceed.Fri, Jul 31, 11:36 PM
inquire_JohnEricson.me added a comment.Fri, Jul 31, 11:41 PM

OK I update the diff via the web form, which I noticed messes up the diff-to-diff comparison, since the base commit is gone, but hopefully that does not matter when landing this.

markj accepted this revision.Tue, Aug 4, 8:57 PM
In D58459#1344377, @inquire_JohnEricson.me wrote:

OK I update the diff via the web form, which I noticed messes up the diff-to-diff comparison, since the base commit is gone, but hopefully that does not matter when landing this.

It doesn't matter for landing.

For what it's worth I find it much easier to upload patches from the command-line, e.g. with git-arc: https://wiki.freebsd.org/Phabricator#Create_a_Revision_via_command_line_.28using_git-arc.29

This revision is now accepted and ready to land.Tue, Aug 4, 8:57 PM
inquire_JohnEricson.me added a comment.Tue, Aug 4, 10:06 PM

For what it's worth I find it much easier to upload patches from the command-line, e.g. with git-arc: https://wiki.freebsd.org/Phabricator#Create_a_Revision_via_command_line_.28using_git-arc.29

OK cool I'll check that out! I do have Arcanist installed locally (I was just on a different computer when I did that small revision) but there is definitely room for improvement. I'll give you wrapper a shot.

Revision Contents
Changeset List

PathSize
sys/
kern/
58 lines

Diff 182707

View Options

sys/kern/uipc_usrreq.c

Loading...