Page MenuHomeFreeBSD
Differential D58462

unix: factor `unp_connectat_peer()` out of `unp_connectat()`
ClosedPublic
Actions

Authored by inquire_JohnEricson.me on Sat, Jul 25, 8:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 18, 3:57 PM
Unknown Object (File)
Tue, Aug 18, 3:28 AM
Unknown Object (File)
Mon, Aug 17, 9:29 PM
Unknown Object (File)
Mon, Aug 17, 2:42 AM
Unknown Object (File)
Mon, Aug 17, 12:29 AM
Unknown Object (File)
Sun, Aug 16, 8:44 PM
Unknown Object (File)
Thu, Aug 13, 10:31 AM
Unknown Object (File)
Tue, Aug 11, 5:09 AM
View All 25 Files
Subscribers
glebius
imp
olce

Details

Reviewers
markj
kib
Commits
rG9b27a22ac696: unix: factor unp_connectat_peer() out of unp_connectat()
Summary

Move the "resolve a connectat(2) target to a referenced peer socket"
half of unp_connectat() -- the namei() lookup and unp_vnode_peer()
call -- into a helper, leaving unp_connectat() with the connection state
machine plus a single unp_connect_peer().

This is where the next change grows the ways a peer can be named; keeping
it a helper up front keeps that change focused on the new resolution
logic.

No functional change intended.

Signed-off-by: John Ericson <John.Ericson@Obsidian.Systems>
Assisted-by: Claude Code (Claude Opus 4.8 and Fable 5)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inquire_JohnEricson.me created this revision.Sat, Jul 25, 8:25 PM
Herald added subscribers: olce, glebius, imp. · View Herald TranscriptSat, Jul 25, 8:25 PM
inquire_JohnEricson.me requested review of this revision.Sat, Jul 25, 8:25 PM
Harbormaster completed remote builds in B75135: Diff 182710.Sat, Jul 25, 8:25 PM
inquire_JohnEricson.me added a parent revision: D58461: unix: factor `unp_vnode_peer()` out of `unp_connectat()`.Sat, Jul 25, 8:25 PM
inquire_JohnEricson.me added a child revision: D58406: tests: exercise unix `connectat(2)` with a socket peer descriptor.Sat, Jul 25, 8:28 PM
inquire_JohnEricson.me added a child revision: D58405: unix: allow `connectat(2)` to name the peer socket by descriptor.
inquire_JohnEricson.me removed a child revision: D58406: tests: exercise unix `connectat(2)` with a socket peer descriptor.Sat, Jul 25, 8:31 PM
markj accepted this revision.Tue, Aug 4, 9:14 PM
This revision is now accepted and ready to land.Tue, Aug 4, 9:14 PM
Closed by commit rG9b27a22ac696: unix: factor unp_connectat_peer() out of unp_connectat() (authored by inquire_JohnEricson.me, committed by markj). · Explain WhyMon, Aug 10, 5:41 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG9b27a22ac696: unix: factor unp_connectat_peer() out of unp_connectat().

Revision Contents
Changeset List

PathSize
sys/
kern/
53 lines

Diff 183808

View Options

sys/kern/uipc_usrreq.c

Loading...