kqueue: Fix delivery of unwanted events
ClosedPublic
Actions

Authored by des on Wed, Jul 22, 3:11 PM.

Details

Reviewers

kib
markj

Commits

rG70b3d322e5b0: kqueue: Fix delivery of unwanted events
rGeeba99aff03b: kqueue: Fix delivery of unwanted events
rG4627fe9e5afc: kqueue: Fix delivery of unwanted events

Summary

In both procdesc_kqops_event() and filt_proc(), the event variable can
have more than one bit set. This means that:

We cannot compare it directly with NOTE_EXIT; we must binary-and them instead.

We cannot binary-or it with the report mask; we must binary-and it with the request mask first.

MFC after: 1 week
Fixes: 2a5e58c59694 ("procdesc: add NOTE_PDSIGCHLD")
Fixes: b328975b9d7c ("procdesc: report NOTE_PDSIGCHLD for traced and stopped process")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75012
Build 71895: arc lint + arc unit

Event Timeline

des created this revision.Wed, Jul 22, 3:11 PM

Herald added subscribers: olce, imp. · View Herald TranscriptWed, Jul 22, 3:11 PM

des requested review of this revision.Wed, Jul 22, 3:11 PM

Harbormaster completed remote builds in B75012: Diff 182462.Wed, Jul 22, 3:11 PM

markj accepted this revision.Wed, Jul 22, 3:16 PM

This revision is now accepted and ready to land.Wed, Jul 22, 3:16 PM

kib accepted this revision.Wed, Jul 22, 9:55 PM

Closed by commit rG4627fe9e5afc: kqueue: Fix delivery of unwanted events (authored by des). · Explain WhyThu, Jul 23, 6:07 AM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG4627fe9e5afc: kqueue: Fix delivery of unwanted events.

des added a commit: rGeeba99aff03b: kqueue: Fix delivery of unwanted events.Mon, Aug 3, 11:38 AM

des added a commit: rG70b3d322e5b0: kqueue: Fix delivery of unwanted events.

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_event.c

6 lines

sys_procdesc.c

4 lines

Diff 182462

View Options

sys/kern/kern_event.c