i386: provide PCPU pc_small_core for amd64 compat
ClosedPublic
Actions

Authored by rlibby on Sun, Jul 19, 3:43 AM.

Details

Reviewers

kib
olce
markj
aokblast

Commits

rGf02f552ad788: i386: provide PCPU pc_small_core for amd64 compat
rG29d15d658d17: i386: provide PCPU pc_small_core for amd64 compat

Summary

Provide pc_small_core for i386 too to fix an i386 build break from x86
code referring to it. It won't be set.

Fixes: 7b26353a59d6 ("hwpstate_intel: Disable package control on hybrid CPU")

Test Plan

make buildkernel for amd64 and i386.

I do not have an appropriate CPU to test the actual functionality.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 74923
Build 71806: arc lint + arc unit

Event Timeline

rlibby created this revision.Sun, Jul 19, 3:43 AM

Herald added a subscriber: imp. · View Herald TranscriptSun, Jul 19, 3:43 AM

rlibby requested review of this revision.Sun, Jul 19, 3:43 AM

Harbormaster completed remote builds in B74923: Diff 182198.Sun, Jul 19, 3:44 AM

rlibby added a child revision: D58336: hwpstate_intel(4): use CPU_FOREACH instead of an IPI.Sun, Jul 19, 3:45 AM

rlibby edited the summary of this revision. (Show Details)Sun, Jul 19, 3:51 AM

rlibby edited the test plan for this revision. (Show Details)

rlibby added reviewers: kib, olce, markj.

aokblast added a subscriber: aokblast.Sun, Jul 19, 2:30 PM

aokblast added inline comments.

sys/amd64/amd64/initcpu.c
265	Sorry for missing this. It solves the problem. But I am wondering if @olce is working on this as intel now has E-Core, P-Core, and LE-Core, which small_cores is not enough. I am good with the change itself.

kib feedback from D58336: just provide pc_small_core on i386

Harbormaster completed remote builds in B74930: Diff 182223.Sun, Jul 19, 3:35 PM

rlibby retitled this revision from x86: memorize the existence of hybrid small cores to i386: provide PCPU pc_small_core for amd64 compat.Sun, Jul 19, 3:39 PM

rlibby edited the summary of this revision. (Show Details)

kib accepted this revision.Sun, Jul 19, 3:40 PM

This revision is now accepted and ready to land.Sun, Jul 19, 3:40 PM

aokblast accepted this revision.Sun, Jul 19, 3:49 PM

Closed by commit rG29d15d658d17: i386: provide PCPU pc_small_core for amd64 compat (authored by rlibby). · Explain WhySun, Jul 19, 8:08 PM

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rG29d15d658d17: i386: provide PCPU pc_small_core for amd64 compat.

olce added a commit: rGf02f552ad788: i386: provide PCPU pc_small_core for amd64 compat.Fri, Jul 24, 4:35 AM