LinuxKPI: pci: fix dma handle type in match function
ClosedPublic
Actions

Authored by bz on Thu, Jul 16, 4:29 PM.

Details

Reviewers

None

Group Reviewers

Commits

rGa7d0df951c90: LinuxKPI: pci: fix dma handle type in match function
rG2099bf27126f: LinuxKPI: pci: fix dma handle type in match function

Summary

dma_addr_t is a vm_paddr_t which is a uint of some width. Rather than
passing pointers of it around pass the value.

Comparing the addresses of different storage for the same dma handle
(the actual bug here) will not work when passed to the devres match
function.

Sponsored by: The FreeBSD Foundation
Fixes: 0a575891211ef ("implement dmam_free_coherent()")
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 74853
Build 71736: arc lint + arc unit

Event Timeline

bz created this revision.Thu, Jul 16, 4:29 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptThu, Jul 16, 4:29 PM

bz requested review of this revision.Thu, Jul 16, 4:29 PM

Harbormaster completed remote builds in B74853: Diff 182084.Thu, Jul 16, 4:29 PM

bz added a child revision: D58295: LinuxKPI: sg_page() remove superfluous ().Fri, Jul 17, 1:20 PM

Anyone on this one?

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Jul 24, 7:35 PM

Closed by commit rG2099bf27126f: LinuxKPI: pci: fix dma handle type in match function (authored by bz). · Explain Why

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG2099bf27126f: LinuxKPI: pci: fix dma handle type in match function.

bz added a commit: rGa7d0df951c90: LinuxKPI: pci: fix dma handle type in match function.Mon, Jul 27, 12:11 AM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

src/

linux_pci.c

8 lines

Diff 182084

View Options

sys/compat/linuxkpi/common/src/linux_pci.c

LinuxKPI: pci: fix dma handle type in match functionClosedPublicActions