Page MenuHomeFreeBSD
Differential D58110

x86/local_apic.c: Factor out version read and max LVT slot computation
ClosedPublic
Actions

Authored by olce on Wed, Jul 8, 1:14 PM.
Tags
None
Referenced Files
F162427371: D58110.id181718.diff
Mon, Jul 13, 3:55 AM
F162425794: D58110.id181539.diff
Mon, Jul 13, 3:39 AM
F162424862: D58110.id181549.diff
Mon, Jul 13, 3:31 AM
F162408203: D58110.diff
Sun, Jul 12, 11:28 PM
F162408019: D58110.diff
Sun, Jul 12, 11:24 PM
F162375249: D58110.id181718.diff
Sun, Jul 12, 3:21 PM
Unknown Object (File)
Sat, Jul 11, 8:57 PM
Subscribers
emaste
imp

Details

Reviewers
bnovkov
kib
Commits
rG060ecf296664: x86/local_apic.c: Factor out version read and max LVT slot computation
Summary

This makes the code slightly more compact and easier to read.

No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 74626
Build 71509: arc lint + arc unit

Event Timeline

olce created this revision.Wed, Jul 8, 1:14 PM
Herald added a subscriber: imp. · View Herald TranscriptWed, Jul 8, 1:14 PM
olce requested review of this revision.Wed, Jul 8, 1:14 PM
olce mentioned this in D58086: x86/local_apic.c: Fiddle with thermal LVT slot only if supported.Wed, Jul 8, 1:14 PM
Harbormaster completed remote builds in B74620: Diff 181539.Wed, Jul 8, 1:14 PM
olce updated this revision to Diff 181549.Wed, Jul 8, 4:38 PM

Be consistent and declare all small helpers as inline.

olce added a reviewer: kib.Wed, Jul 8, 4:38 PM
olce removed a subscriber: kib.
Harbormaster completed remote builds in B74626: Diff 181549.Wed, Jul 8, 4:38 PM
bnovkov accepted this revision.Wed, Jul 8, 8:30 PM
This revision is now accepted and ready to land.Wed, Jul 8, 8:30 PM
kib added inline comments.Thu, Jul 9, 5:08 AM
sys/x86/x86/local_apic.c
383

What is __const?

olce marked an inline comment as done.Thu, Jul 9, 7:26 PM
olce added inline comments.
sys/x86/x86/local_apic.c
383

A mistake, I was thinking about the const attribute to functions. Replace by our __pure2 in my tree.

olce marked an inline comment as done.Thu, Jul 9, 7:26 PM
Closed by commit rG060ecf296664: x86/local_apic.c: Factor out version read and max LVT slot computation (authored by olce). · Explain WhyFri, Jul 10, 3:31 PM
This revision was automatically updated to reflect the committed changes.
olce added a commit: rG060ecf296664: x86/local_apic.c: Factor out version read and max LVT slot computation.

Revision Contents
Changeset List

PathSize
sys/
x86/
x86/
72 lines

Diff 181549

View Options

sys/x86/x86/local_apic.c

Loading...