Paths

Table of Contentst

link_elf: Program-header bounds check is non‑fatal (link_elf_load_file)
AbandonedPublic
Actions

Authored by thebugfixers_pm.me on Jun 23 2026, 8:50 PM.

Tags

None

Referenced Files

	F165229422: D57788.diff
	Fri, Aug 7, 12:38 AM

	F165221515: D57788.diff
	Thu, Aug 6, 10:56 PM

	Unknown Object (File)
	Tue, Aug 4, 9:19 PM

	Unknown Object (File)
	Thu, Jul 30, 10:42 AM

	Unknown Object (File)
	Tue, Jul 28, 3:57 PM

	Unknown Object (File)
	Jul 5 2026, 7:23 PM

	Unknown Object (File)
	Jul 5 2026, 7:20 PM

	Unknown Object (File)
	Jul 5 2026, 10:57 AM

Subscribers

Details

Reviewers

jrtc27

Group Reviewers

Src Committers
Contributor Reviews (src)

Summary

Bug: Logs the error but does not return.

Fix: add error = ENOEXEC; goto out; after the link_elf_error call.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

thebugfixers_pm.me created this revision.Jun 23 2026, 8:50 PM

Herald added subscribers: olce, imp. · View Herald TranscriptJun 23 2026, 8:50 PM

thebugfixers_pm.me requested review of this revision.Jun 23 2026, 8:50 PM

thebugfixers_pm.me added a parent revision: D57785: link_elf: Guard against subtraction underflow.Jun 26 2026, 5:25 PM

I don't think you tested this.

sys/kern/link_elf.c
1092	https://en.wikipedia.org/wiki/Unreachable_code#goto_fail_bug

This revision now requires changes to proceed.Wed, Jul 29, 2:04 PM

Fixed properly in 1e39a314d870e312f623199e146eda6bdbc293a3.

Agree it looks like it slipped through the net. Not sure on the why/how, I will investigate that in my own time, but the right thing to do is to abandon the proposal.

Thank you for your time pointing this out.

Revision Contents
Changeset List

Path

Size

sys/

kern/

link_elf.c

2 lines

Diff 180452

View Options

link_elf: Program-header bounds check is non‑fatal (link_elf_load_file)AbandonedPublicActions