link_elf: Unvalidated string‑table offset (link_elf_lookup_symbol1)
Needs ReviewPublic
Actions

Authored by thebugfixers_pm.me on Wed, Jun 24, 9:08 AM.

Tags

None

Referenced Files

	F162723333: D57810.diff
	Thu, Jul 16, 4:19 AM

	Unknown Object (File)
	Mon, Jul 6, 2:05 PM

	Unknown Object (File)
	Fri, Jul 3, 10:26 PM

	Unknown Object (File)
	Thu, Jul 2, 11:01 PM

	Unknown Object (File)
	Thu, Jul 2, 10:51 PM

	Unknown Object (File)
	Thu, Jul 2, 10:42 PM

	Unknown Object (File)
	Thu, Jul 2, 7:10 AM

	Unknown Object (File)
	Fri, Jun 26, 9:23 AM

View All 9 Files

Subscribers

imp

olce

Details

Reviewers

None

Group Reviewers

Src Committers
Contributor Reviews (src)

Summary

st_name is never checked against ef->strsz

The existing test st_name == 0 only weeds out symbols that have no string; it does not stop a bogus, out-of-range offset from being used.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

thebugfixers_pm.me created this revision.Wed, Jun 24, 9:08 AM

Herald added subscribers: olce, imp. · View Herald TranscriptWed, Jun 24, 9:08 AM

thebugfixers_pm.me requested review of this revision.Wed, Jun 24, 9:08 AM

thebugfixers_pm.me added a parent revision: D57785: link_elf: Guard against subtraction underflow.Fri, Jun 26, 5:25 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

link_elf.c

5 lines

Diff 180514

View Options

link_elf: Unvalidated string‑table offset (link_elf_lookup_symbol1)Needs ReviewPublicActions