cd9660: Add support for birth times
ClosedPublic
Actions

Authored by jhb on Wed, Jun 10, 2:35 PM.

Details

Reviewers

des
emaste
markj

Commits

rG3d945604ef8e: cd9660: Add support for birth times

Summary

Both the Extended Attribute Record in the base ISO-9660 standard and
the RockRidge timestamp extension support a file creation timestamp.
Use this to populate the birthtime if present.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 74108
Build 70991: arc lint + arc unit

Event Timeline

jhb created this revision.Wed, Jun 10, 2:35 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Jun 10, 2:35 PM

jhb requested review of this revision.Wed, Jun 10, 2:35 PM

Harbormaster completed remote builds in B73804: Diff 179572.Wed, Jun 10, 2:35 PM

jlduran added a subscriber: jlduran.Wed, Jun 10, 5:57 PM

markj accepted this revision.Mon, Jun 15, 2:16 PM

markj added inline comments.

sys/fs/cd9660/cd9660_node.c
181	Why is it okay to ignore a conversion failure here? Ah, the birthtime will just be zeroed out in that case. I'd at least add an explicit cast to void for the return value.

This revision is now accepted and ready to land.Mon, Jun 15, 2:16 PM

Rebase on top of D57748

This revision now requires review to proceed.Mon, Jun 22, 5:33 PM

Harbormaster completed remote builds in B74108: Diff 180314.Mon, Jun 22, 5:33 PM

jhb added a parent revision: D57748: cd9660: Adjust parsing of timestamps in the extended atttributes record.Mon, Jun 22, 5:33 PM

jhb added inline comments.

sys/fs/cd9660/cd9660_node.c
181	I've addressed this in the parent review I think where I use a more explicit memset just as in the RRIP code. I ended up doing a bit more work in that parent review as upon closer review, the parsing of the timestamps in this function before was just odd.