netlink: Use unsigned type in nl_process_nbuf
ClosedPublic
Actions

Authored by emaste on Fri, Jun 5, 7:20 PM.

Details

Reviewers

pouria
melifaro
glebius

Group Reviewers

network

Commits

rG3151fdd90bf1: netlink: Use unsigned type in nl_process_nbuf
rG888d9236e224: netlink: Use unsigned type in nl_process_nbuf

Summary

nlmsghdr::nlmsg_len and nl_buf::offset are u_int. Make msglen match.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste created this revision.Fri, Jun 5, 7:20 PM

Herald added a reviewer: melifaro. · View Herald TranscriptFri, Jun 5, 7:20 PM

Herald added subscribers: glebius, melifaro. · View Herald Transcript

emaste requested review of this revision.Fri, Jun 5, 7:20 PM

pouria accepted this revision.Fri, Jun 5, 7:24 PM

This revision is now accepted and ready to land.Fri, Jun 5, 7:24 PM

Original Netlink submission had a ton of violations like that and we are slowly but surely fixing them.

sys/netlink/netlink_io.c
347–352	While here I'd suggest to bring this to style.

This revision now requires changes to proceed.Mon, Jun 8, 6:03 PM

var declaration at top of block

glebius accepted this revision as: glebius.Mon, Jun 8, 7:19 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Jun 8, 7:52 PM

Closed by commit rG888d9236e224: netlink: Use unsigned type in nl_process_nbuf (authored by emaste). · Explain Why

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG888d9236e224: netlink: Use unsigned type in nl_process_nbuf.

Herald added a subscriber: imp. · View Herald TranscriptMon, Jun 8, 7:52 PM

emaste added a commit: rG3151fdd90bf1: netlink: Use unsigned type in nl_process_nbuf.Thu, Jun 11, 5:08 PM

Revision Contents
Changeset List

Path

Size

sys/

netlink/

netlink_io.c

4 lines

Diff 179401

View Options

netlink: Use unsigned type in nl_process_nbufClosedPublicActions