acpi_spmc(4): Fix comments on constraints storage
ClosedPublic
Actions

Authored by olce on Mon, May 4, 8:29 PM.

Tags

None

Referenced Files

	F157884689: D56798.id177735.diff
	Tue, May 26, 3:58 AM

	Unknown Object (File)
	Sun, May 24, 3:47 AM

	Unknown Object (File)
	Fri, May 22, 7:49 PM

	Unknown Object (File)
	Thu, May 21, 9:45 PM

	Unknown Object (File)
	Wed, May 20, 5:08 AM

	Unknown Object (File)
	Sat, May 16, 4:31 AM

	Unknown Object (File)
	Sat, May 16, 2:48 AM

	Unknown Object (File)
	Thu, May 14, 12:40 PM

View All 17 Files

Subscribers

emaste

imp

Details

Reviewers

obiwac
emaste
imp

Commits

rGa652d9763059: acpi_spmc(4): Fix comments on constraints storage

Summary

The fields themselves are not unused, we actually fill them, but once
filled we indeed do not use their values (yet). See the '#ifdef notyet'
section in acpi_spmc_check_constraints().

No functional change.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

olce created this revision.Mon, May 4, 8:29 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, May 4, 8:29 PM

olce requested review of this revision.Mon, May 4, 8:29 PM

Harbormaster completed remote builds in B72783: Diff 177189.Mon, May 4, 8:29 PM

olce added a child revision: D56799: acpi_spmc(4): Remove XXX from a comment about retrieving constraints.Mon, May 4, 8:38 PM

emaste accepted this revision.Mon, May 4, 9:53 PM

This revision is now accepted and ready to land.Mon, May 4, 9:53 PM

obiwac accepted this revision.Tue, May 5, 1:52 PM

imp accepted this revision.Thu, May 7, 2:40 AM

Closed by commit rGa652d9763059: acpi_spmc(4): Fix comments on constraints storage (authored by olce). · Explain WhyWed, May 13, 12:39 PM

This revision was automatically updated to reflect the committed changes.

olce added a commit: rGa652d9763059: acpi_spmc(4): Fix comments on constraints storage.

Revision Contents
Changeset List

Path

Size

sys/

dev/

acpica/

acpi_spmc.c

4 lines

Diff 177735

View Options

sys/dev/acpica/acpi_spmc.c

acpi_spmc(4): Fix comments on constraints storageClosedPublicActions