acpi_spmc(4): Fix comments on constraints storage
ClosedPublic
Actions

Authored by olce on May 4 2026, 8:29 PM.

Details

Reviewers

obiwac
emaste
imp

Commits

rGa652d9763059: acpi_spmc(4): Fix comments on constraints storage

Summary

The fields themselves are not unused, we actually fill them, but once
filled we indeed do not use their values (yet). See the '#ifdef notyet'
section in acpi_spmc_check_constraints().

No functional change.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 72783
Build 69666: arc lint + arc unit

Event Timeline

olce created this revision.May 4 2026, 8:29 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 4 2026, 8:29 PM

olce requested review of this revision.May 4 2026, 8:29 PM

Harbormaster completed remote builds in B72783: Diff 177189.May 4 2026, 8:29 PM

olce added a child revision: D56799: acpi_spmc(4): Remove XXX from a comment about retrieving constraints.May 4 2026, 8:38 PM

emaste accepted this revision.May 4 2026, 9:53 PM

This revision is now accepted and ready to land.May 4 2026, 9:53 PM

obiwac accepted this revision.May 5 2026, 1:52 PM

imp accepted this revision.May 7 2026, 2:40 AM

Closed by commit rGa652d9763059: acpi_spmc(4): Fix comments on constraints storage (authored by olce). · Explain WhyMay 13 2026, 12:39 PM

This revision was automatically updated to reflect the committed changes.

olce added a commit: rGa652d9763059: acpi_spmc(4): Fix comments on constraints storage.

Revision Contents
Changeset List

Path

Size

sys/

dev/

acpica/

acpi_spmc.c

4 lines

Diff 177189

View Options

sys/dev/acpica/acpi_spmc.c

acpi_spmc(4): Fix comments on constraints storageClosedPublicActions