Page MenuHomeFreeBSD
Differential D54079

build.7: Improve make delete-old example
Needs ReviewPublic
Actions

Authored by ziaee on Dec 4 2025, 9:11 PM.
Tags
None
Referenced Files
F152500889: D54079.id174976.diff
Wed, Apr 15, 8:53 AM
F152449716: D54079.id174978.diff
Wed, Apr 15, 1:13 AM
F152427510: D54079.id174978.diff
Tue, Apr 14, 9:53 PM
Unknown Object (File)
Tue, Apr 14, 10:22 AM
Unknown Object (File)
Mon, Apr 13, 12:52 PM
Unknown Object (File)
Sat, Apr 11, 7:34 PM
Unknown Object (File)
Sat, Apr 11, 2:59 PM
Unknown Object (File)
Tue, Apr 7, 7:13 PM
View All 27 Files
Subscribers
emaste
fuz
imp

Details

Reviewers
jbo
jhb
Group Reviewers
manpages
Summary

Be more explicit that deleting old files and libraries needs to be
really after you're rebooted a third time and you're really actually
sure your applications aren't using old libs, following irc discussion.

Also adjust an example slightly to fit on 80 character console.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 72001
Build 68884: arc lint + arc unit

Event Timeline

ziaee created this revision.Dec 4 2025, 9:11 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 4 2025, 9:11 PM
ziaee requested review of this revision.Dec 4 2025, 9:11 PM
Harbormaster completed remote builds in B69058: Diff 167560.Dec 4 2025, 9:11 PM
fuz added a subscriber: fuz.Dec 18 2025, 3:30 PM
fuz added inline comments.
share/man/man7/build.7
1117

Should be consistent, also check for additional occurrences.

ziaee updated this revision to Diff 168329.Dec 18 2025, 4:19 PM

switch examples consistently to /client, thanks @fuz!

Harbormaster completed remote builds in B69373: Diff 168329.Dec 18 2025, 4:19 PM
jhb added inline comments.Jan 28 2026, 9:51 PM
share/man/man7/build.7
1026–1027

I would be tempted to leave make delete-old here and only defer make delete-old-libs to the new paragraph. In practice I always run make delete-old right after etcupdate -B. It's only make delete-old-libs that I defer until after updating packages.

ziaee added a child revision: D56217: build.7: Explain packaging a custom kernel.Wed, Apr 1, 4:00 PM
emaste added a subscriber: emaste.Wed, Apr 1, 4:33 PM
emaste added inline comments.
share/man/man7/build.7
1026–1027

Agreed. They're split into two targets for a reason.

ziaee updated this revision to Diff 174976.Mon, Apr 6, 4:10 PM

thanks for review guys!

Harbormaster completed remote builds in B71998: Diff 174976.Mon, Apr 6, 4:10 PM
ziaee updated this revision to Diff 174977.Mon, Apr 6, 4:25 PM

rebase due to addressing feedback in previous revision.

i didn't report this

i got this information from your mail on the pkgbase list, iiuc im supposed to then credit you with reported by.

i think we also need to document the behaviour of building multiple kernels in KERNCONF

agree. i think we should put that in the KERNCONF entry, im going to attempt it in a subsequent revision.

Harbormaster completed remote builds in B71999: Diff 174977.Mon, Apr 6, 4:25 PM
ziaee updated this revision to Diff 174978.Mon, Apr 6, 4:32 PM

fix rebase error

Harbormaster completed remote builds in B72000: Diff 174978.Mon, Apr 6, 4:32 PM
ziaee updated this revision to Diff 174979.Mon, Apr 6, 4:37 PM

sorry, last attempt at diff actually just made it worse, i think this is the correct diff

Harbormaster completed remote builds in B72001: Diff 174979.Mon, Apr 6, 4:37 PM

Revision Contents
Changeset List

PathSize
share/
man/
man7/
18 lines

Diff 174979

View Options

share/man/man7/build.7

Loading...