routing: Implement merge of nhgrp in new multipath route
Needs ReviewPublic
Actions

Authored by pouria on Tue, Mar 31, 4:08 PM.

Details

Reviewers

kp
markj
glebius
zlei
melifaro

Group Reviewers

network

Summary

Routing subsystem allows creating new multipath routes by
nexthop groups (e.g RTA_MULTIPATH in netlink), in case of
a second nexthop group on the same route, don't panic and
merge the existing nhgrp with new one.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71865
Build 68748: arc lint + arc unit

Event Timeline

pouria created this revision.Tue, Mar 31, 4:08 PM

Herald added a reviewer: melifaro. · View Herald TranscriptTue, Mar 31, 4:08 PM

Herald added subscribers: melifaro, ae, imp. · View Herald Transcript

pouria requested review of this revision.Tue, Mar 31, 4:08 PM

pouria added a child revision: D56188: netlink: Fix RTA_MULTIPATH on RTM_GETROUTE.

Harbormaster completed remote builds in B71865: Diff 174671.Tue, Mar 31, 4:09 PM

For tests, see D56190.

sys/net/route/nhgrp_ctl.c
836–838	For reviewers, it's meaningless to reference nhops of an nhgrp here like above. Therefore, I didn't.
843–845	For reviewers, don't worry about the reverse order here, it will eventually sorted by qsort.

For reviewers: this patch also fixes a panic caused by an incorrect assumption in nhgrp_get_addition_group().
That function assumes rnd->rnd_nhop is not an nhgrp_object, therefore sending two or more RTA_MULTIPATH attributes can trigger a panic.

pouria added a comment.Tue, Mar 31, 5:02 PM

This comment was removed by pouria.

glebius added inline comments.Tue, Mar 31, 6:30 PM