Page MenuHomeFreeBSD
Differential D55905

ndp: Accept multiple queued ND for non-GRAND NAs
ClosedPublic
Actions

Authored by pouria on Tue, Mar 17, 8:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 8, 9:55 AM
Unknown Object (File)
Tue, Apr 7, 7:33 AM
Unknown Object (File)
Sun, Apr 5, 1:21 PM
Unknown Object (File)
Sat, Mar 28, 4:46 PM
Unknown Object (File)
Wed, Mar 25, 9:04 AM
Unknown Object (File)
Wed, Mar 25, 9:04 AM
Unknown Object (File)
Tue, Mar 24, 9:28 PM
Unknown Object (File)
Tue, Mar 24, 1:42 PM
View All 23 Files
Subscribers
ae
bms
imp
melifaro

Details

Reviewers
glebius
zlei
adrian
Group Reviewers
network
Commits
rG15ebee7c2ed3: ndp: Accept multiple queued ND for non-GRAND NAs
Summary

Multiple delayed NAs on the same ifa can occur simultaneously.
Therefore:

  • Differentiate between GRAND and solicited replies.
  • Cancel previous pending GRAND NA for same ifa.
  • Reuse ndq memory for GRAND.
  • Free non-GRAND replies immediately.
  • Don't limit non-GRAND NAs.
Test Plan

Increase grand count before running tests:

sysctl net.inet6.ip6.grand_count=10

then, simply run kyua network tests:

kyua -k /usr/tests/Kyuafile sys/net
kyua -k /usr/tests/Kyuafile sys/netinet6
kyua -k /usr/tests/Kyuafile sys/netlink
kyua -k /usr/tests/Kyuafile sys/netgraph

or you can add multiple v6 addresses followed by changing
the mac address of interface.
Do it in jail and destroy it for stress.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 71473
Build 68356: arc lint + arc unit

Event Timeline

pouria created this revision.Tue, Mar 17, 8:57 PM
Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptTue, Mar 17, 8:57 PM
pouria requested review of this revision.Tue, Mar 17, 8:57 PM
Harbormaster completed remote builds in B71470: Diff 173827.Tue, Mar 17, 8:57 PM
pouria updated this revision to Diff 173828.Tue, Mar 17, 10:01 PM

Don't count for grand for delayed solicited NAs.

Harbormaster completed remote builds in B71471: Diff 173828.Tue, Mar 17, 10:01 PM
pouria updated this revision to Diff 173829.Tue, Mar 17, 11:45 PM

Reuse ndq and cancel out previous pending NA for same ifa.
@glebius done.

Harbormaster completed remote builds in B71472: Diff 173829.Tue, Mar 17, 11:45 PM
pouria edited the summary of this revision. (Show Details)Tue, Mar 17, 11:47 PM
pouria updated this revision to Diff 173830.Tue, Mar 17, 11:53 PM

Fix a minor issue on PATH_MASK.

Harbormaster completed remote builds in B71473: Diff 173830.Tue, Mar 17, 11:53 PM
glebius added inline comments.Wed, Mar 18, 12:11 AM
sys/netinet6/nd6_nbr.c
1769–1784

This logic can be achieved without new boolean, just using blocks. Also we need not to leak a lock in case of malloc(9) failure.

1871–1872

I would say that previous version was easier to read. A single version of nd6_queue_rel() that requires lock on entry and returns unlocked. Then in this cycle use return; instead of break;. Basically nd6_queue_stop() doesn't need any changes. And second version of nd6_queue_rel_locked() isn't needed.

glebius added a comment.Wed, Mar 18, 12:13 AM

I'd suggest to use more specific commit line, e.g. ndp: handle a case when two timers coalesce for the same ifa. Or something else that you can come up with. Just more specific than "make things better" :)

pouria updated this revision to Diff 173874.EditedWed, Mar 18, 11:18 PM

Address @glebius comments and update according to our conversation.

ndp: Accept multiple queued ND for non-GRAND NAs

Multiple delayed NAs on the same ifa can occur simultaneously.
Therefore:
* Differentiate between GRAND and solicited replies.
* Cancel previous pending GRAND NA for same ifa.
* Reuse ndq memory for GRAND.
* Free non-GRAND replies immediately.
* Don't limit non-GRAND NAs.

See also D55927 for one the tests.

Harbormaster completed remote builds in B71499: Diff 173874.Wed, Mar 18, 11:18 PM
pouria retitled this revision from ndp: Improve robustness of nd_queue to ndp: Accept multiple queued ND for non-GRAND NAs.Wed, Mar 18, 11:19 PM
pouria edited the summary of this revision. (Show Details)
pouria edited the summary of this revision. (Show Details)Wed, Mar 18, 11:31 PM
glebius accepted this revision as: glebius.Wed, Mar 18, 11:36 PM
This revision is now accepted and ready to land.Wed, Mar 18, 11:36 PM
pouria mentioned this in D55850: nd6: Fix delayed proxy address.Thu, Mar 19, 2:15 PM
pouria added a child revision: D55850: nd6: Fix delayed proxy address.Thu, Mar 19, 2:16 PM
Closed by commit rG15ebee7c2ed3: ndp: Accept multiple queued ND for non-GRAND NAs (authored by pouria). · Explain WhyThu, Mar 19, 4:23 PM
This revision was automatically updated to reflect the committed changes.
pouria added a commit: rG15ebee7c2ed3: ndp: Accept multiple queued ND for non-GRAND NAs.

Revision Contents
Changeset List

PathSize
sys/
netinet6/
6 lines
112 lines

Diff 173830

View Options

sys/netinet6/nd6.h

Loading...
View Options

sys/netinet6/nd6_nbr.c

Loading...