Paths

Table of Contentst

Differential D55544

asmc(4): pull 32-bit support for the driver
ClosedPublic
Actions

Authored by ngie on Thu, Feb 26, 9:24 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Feb 27, 6:28 AM

	Unknown Object (File)
	Fri, Feb 27, 2:05 AM

	Unknown Object (File)
	Fri, Feb 27, 1:49 AM

	Unknown Object (File)
	Fri, Feb 27, 12:59 AM

Subscribers

Details

Reviewers

des
olce

Commits

rG1f2f5eba24aa: asmc(4): pull 32-bit support for the driver

Summary

The asmc(4) driver should work for 32-bit Intel-based Macs, in theory, if
the model details were added to the detection list. That being said,
32-bit Intel Macs were only released and available to the general public
for 8 months [1], so the value in maintaining i386 support is diminished
due to limited hardware access.

Remove 32-bit support for the driver officially to make it clear its use is
not supported.

This should fix building NOTES.i386 by proxy as well.

Relnotes: yes
MFC after: 2 weeks
Fixes: f224591746b ("Add ASMC_DEBUG make option")
Fixes: 8342d9f7b5f ("asmc(4): Stop building it on i386, as...")

Test Plan

I've been using this patch in one of my local git trees for quite a while and have run the change through make universe at least once.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71058
Build 67941: arc lint + arc unit

Event Timeline

ngie created this revision.Thu, Feb 26, 9:24 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Feb 26, 9:24 PM

ngie requested review of this revision.Thu, Feb 26, 9:24 PM

Harbormaster completed remote builds in B71036: Diff 172795.Thu, Feb 26, 9:24 PM

ngie edited the test plan for this revision. (Show Details)Thu, Feb 26, 9:25 PM

ngie added a reviewer: des.

ngie added subscribers: guest-seuros, markj, adrian.

ngie added a reviewer: olce.Thu, Feb 26, 9:55 PM

ngie edited the summary of this revision. (Show Details)

ngie added inline comments.Fri, Feb 27, 6:02 AM

sys/conf/files.amd64
114 ↗	(On Diff #172795)	This is unnecessary. Not sure why this is in this diff.

Remove superfluous line added to sys/conf/files.amd64 by accident

Harbormaster completed remote builds in B71058: Diff 172843.Fri, Feb 27, 7:04 AM

des accepted this revision.Fri, Feb 27, 9:45 AM

This revision is now accepted and ready to land.Fri, Feb 27, 9:45 AM

Closed by commit rG1f2f5eba24aa: asmc(4): pull 32-bit support for the driver (authored by ngie). · Explain WhyFri, Feb 27, 7:44 PM

This revision was automatically updated to reflect the committed changes.

ngie added a commit: rG1f2f5eba24aa: asmc(4): pull 32-bit support for the driver.

Revision Contents
Changeset List

Path

Size

sys/

x86/

conf/

2 lines

Diff 172843

sys/x86/conf/NOTES

Loading...