Page MenuHomeFreeBSD
Differential D55442

rtnetlink: Add support for nexthop expiration in new route
ClosedPublic
Actions

Authored by pouria on Sun, Feb 22, 6:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 13, 4:13 AM
Unknown Object (File)
Fri, Mar 13, 2:28 AM
Unknown Object (File)
Thu, Mar 12, 7:22 PM
Unknown Object (File)
Wed, Mar 11, 5:05 PM
Unknown Object (File)
Wed, Mar 11, 10:28 AM
Unknown Object (File)
Mon, Mar 9, 11:12 PM
Unknown Object (File)
Mon, Mar 9, 4:50 PM
Unknown Object (File)
Mon, Mar 9, 3:52 AM
View All 21 Files
Subscribers
imp
zarychtam_plan-b.pwste.edu.pl

Details

Reviewers
glebius
melifaro
zlei
markj
Group Reviewers
network
Commits
rGff6d1faa65a1: rtnetlink: Add support for nexthop expiration in new/get route
Summary

Before this change, netlink only shows nexthop
expire value. Now it can set expire time during route creation.

Test Plan

kyua test -k /usr/tests/sys/netlink/Kyuafile
and upcoming route(8) patch for netlink.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 70994
Build 67877: arc lint + arc unit

Event Timeline

pouria created this revision.Sun, Feb 22, 6:40 PM
Herald added a subscriber: imp. · View Herald TranscriptSun, Feb 22, 6:40 PM
pouria requested review of this revision.Sun, Feb 22, 6:40 PM
Harbormaster completed remote builds in B70882: Diff 172456.Sun, Feb 22, 6:40 PM
pouria added a child revision: D55444: route: Fix -expire argument when using netlink.Sun, Feb 22, 6:45 PM
pouria mentioned this in D55445: snl: Remove duplicate rta_expires member in route parser.Sun, Feb 22, 6:55 PM
pouria updated this revision to Diff 172686.Wed, Feb 25, 4:34 PM

Add support for nexthop expire value on multipath routes.
route(8) and netstat(1) will be updated too.

Harbormaster completed remote builds in B70994: Diff 172686.Wed, Feb 25, 4:34 PM
pouria added a child revision: D55440: netlink: Fix expire column in -r flag using netlink.Wed, Feb 25, 4:39 PM
pouria added a child revision: D55514: route(8): show expire time of each nexthop in monitor.Wed, Feb 25, 4:55 PM
glebius accepted this revision as: glebius.Thu, Feb 26, 3:14 AM
glebius added inline comments.
sys/netlink/route/rt.c
182

Please declare nh_expire here. I know netlink violates that part of style(9) a lot, but let's not add new cases.

This revision is now accepted and ready to land.Thu, Feb 26, 3:14 AM
pouria updated this revision to Diff 172760.Thu, Feb 26, 9:13 AM

Address Gleb comment.

This revision now requires review to proceed.Thu, Feb 26, 9:13 AM
Harbormaster completed remote builds in B71025: Diff 172760.Thu, Feb 26, 9:13 AM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, Feb 26, 12:35 PM
Closed by commit rGff6d1faa65a1: rtnetlink: Add support for nexthop expiration in new/get route (authored by pouria). · Explain Why
This revision was automatically updated to reflect the committed changes.
pouria added a commit: rGff6d1faa65a1: rtnetlink: Add support for nexthop expiration in new/get route.
zarychtam_plan-b.pwste.edu.pl added a subscriber: zarychtam_plan-b.pwste.edu.pl.Wed, Mar 4, 5:06 AM

I have been testing this patch on a couple of computers for over a week now, and everything seems to work fine (at least I see no regression).

Revision Contents
Changeset List

PathSize
sys/
netlink/
2 lines
route/
10 lines

Diff 172686

View Options

sys/netlink/netlink_snl_route_parsers.h

Loading...
View Options

sys/netlink/route/rt.c

Loading...