Page MenuHomeFreeBSD
Differential D55438

bhyve: Fix truncate_iov()
ClosedPublic
Actions

Authored by markj on Sun, Feb 22, 4:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 26, 8:56 AM
Unknown Object (File)
Wed, Feb 25, 7:43 PM
Unknown Object (File)
Wed, Feb 25, 7:04 PM
Unknown Object (File)
Wed, Feb 25, 11:24 AM
Unknown Object (File)
Wed, Feb 25, 9:53 AM
Unknown Object (File)
Wed, Feb 25, 7:18 AM
Unknown Object (File)
Wed, Feb 25, 4:39 AM
Unknown Object (File)
Wed, Feb 25, 4:22 AM
View All 13 Files
Subscribers
bcran
des
imp
rgrimes

Details

Reviewers
rosenfeld_grumpf.hope-2000.org
des
emaste
Group Reviewers
bhyve
Commits
rGd7d4da91de20: bhyve: Fix truncate_iov()
Summary

The implementation was simply wrong. It would always just return the
first entry in the iovec, even if the requested length is larger than
that first entry.

Note, this function will be removed soon, see D53468.

Reported by: Vinod p n <vinod272@gmail.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70878
Build 67761: arc lint + arc unit

Event Timeline

markj created this revision.Sun, Feb 22, 4:16 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptSun, Feb 22, 4:16 PM
markj requested review of this revision.Sun, Feb 22, 4:16 PM
Harbormaster completed remote builds in B70878: Diff 172447.Sun, Feb 22, 4:16 PM
emaste added a reviewer: rosenfeld_grumpf.hope-2000.org.Sun, Feb 22, 6:27 PM
rosenfeld_grumpf.hope-2000.org accepted this revision.Sun, Feb 22, 6:31 PM
This revision is now accepted and ready to land.Sun, Feb 22, 6:31 PM
des added a subscriber: des.Mon, Feb 23, 12:24 AM
des added inline comments.
usr.sbin/bhyve/iov.c
88

I found this slightly confusing...

(personally I would have dropped done and just decremented length until it reached 0)

markj updated this revision to Diff 172475.Mon, Feb 23, 12:50 AM

Take Dag-Erling's suggestions.

This revision now requires review to proceed.Mon, Feb 23, 12:50 AM
Harbormaster completed remote builds in B70894: Diff 172475.Mon, Feb 23, 12:50 AM
des accepted this revision.Mon, Feb 23, 1:50 AM
This revision is now accepted and ready to land.Mon, Feb 23, 1:50 AM
rosenfeld_grumpf.hope-2000.org accepted this revision.Mon, Feb 23, 9:14 AM
emaste accepted this revision.Mon, Feb 23, 3:32 PM
Closed by commit rGd7d4da91de20: bhyve: Fix truncate_iov() (authored by markj). · Explain WhyTue, Feb 24, 3:16 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGd7d4da91de20: bhyve: Fix truncate_iov().

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
17 lines

Diff 172447

View Options

usr.sbin/bhyve/iov.c

Loading...