Page MenuHomeFreeBSD
Differential D55438

bhyve: Fix truncate_iov()
ClosedPublic
Actions

Authored by markj on Feb 22 2026, 4:16 PM.
Tags
None
Referenced Files
F168547651: D55438.id172447.diff
Fri, Aug 28, 11:20 PM
F168547554: D55438.diff
Fri, Aug 28, 11:19 PM
Unknown Object (File)
Wed, Aug 26, 12:01 PM
Unknown Object (File)
Wed, Aug 26, 4:19 AM
Unknown Object (File)
Mon, Aug 24, 9:07 PM
Unknown Object (File)
Mon, Aug 24, 12:14 PM
Unknown Object (File)
Sun, Aug 23, 7:17 PM
Unknown Object (File)
Sat, Aug 22, 10:28 AM
View All 98 Files
Subscribers
bcran
des
imp
rgrimes

Details

Reviewers
rosenfeld_grumpf.hope-2000.org
des
emaste
Group Reviewers
bhyve
Commits
rG969c436a6c91: bhyve: Fix truncate_iov()
rG119bdea35792: bhyve: Fix truncate_iov()
rGd7d4da91de20: bhyve: Fix truncate_iov()
Summary

The implementation was simply wrong. It would always just return the
first entry in the iovec, even if the requested length is larger than
that first entry.

Note, this function will be removed soon, see D53468.

Reported by: Vinod p n <vinod272@gmail.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70894
Build 67777: arc lint + arc unit

Event Timeline

markj created this revision.Feb 22 2026, 4:16 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptFeb 22 2026, 4:16 PM
markj requested review of this revision.Feb 22 2026, 4:16 PM
Harbormaster completed remote builds in B70878: Diff 172447.Feb 22 2026, 4:16 PM
emaste added a reviewer: rosenfeld_grumpf.hope-2000.org.Feb 22 2026, 6:27 PM
rosenfeld_grumpf.hope-2000.org accepted this revision.Feb 22 2026, 6:31 PM
This revision is now accepted and ready to land.Feb 22 2026, 6:31 PM
des added a subscriber: des.Feb 23 2026, 12:24 AM
des added inline comments.
usr.sbin/bhyve/iov.c
87

I found this slightly confusing...

(personally I would have dropped done and just decremented length until it reached 0)

markj updated this revision to Diff 172475.Feb 23 2026, 12:50 AM

Take Dag-Erling's suggestions.

This revision now requires review to proceed.Feb 23 2026, 12:50 AM
Harbormaster completed remote builds in B70894: Diff 172475.Feb 23 2026, 12:50 AM
des accepted this revision.Feb 23 2026, 1:50 AM
This revision is now accepted and ready to land.Feb 23 2026, 1:50 AM
rosenfeld_grumpf.hope-2000.org accepted this revision.Feb 23 2026, 9:14 AM
emaste accepted this revision.Feb 23 2026, 3:32 PM
Closed by commit rGd7d4da91de20: bhyve: Fix truncate_iov() (authored by markj). · Explain WhyFeb 24 2026, 3:16 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGd7d4da91de20: bhyve: Fix truncate_iov().
emaste added a commit: rG119bdea35792: bhyve: Fix truncate_iov().Mar 4 2026, 3:59 PM
emaste added a commit: rG969c436a6c91: bhyve: Fix truncate_iov().Mar 9 2026, 1:27 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
15 lines

Diff 172475

View Options

usr.sbin/bhyve/iov.c

Loading...