Page MenuHomeFreeBSD
Differential D55410

tcp: improve validation of received TCP over UDP packets
ClosedPublic
Actions

Authored by tuexen on Fri, Feb 20, 8:46 PM.
Tags
None
Referenced Files
F145654419: D55410.diff
Sun, Feb 22, 5:20 PM
Unknown Object (File)
Fri, Feb 20, 9:17 PM
Subscribers
bms
gnn
imp
melifaro
pouria
rgrimes

Details

Reviewers
rrs
glebius
timo.voelker_fh-muenster.de
pouria
Group Reviewers
transport
Commits
rGe1886559ea47: tcp: improve validation of received TCP over UDP packets

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

tuexen created this revision.Fri, Feb 20, 8:46 PM
Herald added a reviewer: transport. · View Herald TranscriptFri, Feb 20, 8:46 PM
Herald added subscribers: melifaro, imp. · View Herald Transcript
tuexen requested review of this revision.Fri, Feb 20, 8:46 PM
pouria accepted this revision as: pouria.Fri, Feb 20, 9:02 PM
pouria added a subscriber: pouria.

LGTM

sys/netinet/tcp_subr.c
623

__predict_false?

glebius added a comment.Fri, Feb 20, 9:05 PM

I'd suggest to change to title to explictily say "TCP over UDP", cause "TCP/UDP" can be misinterpreted to a change to TCP and a similar change to UDP.

glebius accepted this revision.Fri, Feb 20, 9:06 PM
tuexen retitled this revision from tcp: improve validation of received TCP/UDP packets to tcp: improve validation of received TCP over UDP packets.Fri, Feb 20, 9:12 PM
tuexen accepted this revision as: transport.Fri, Feb 20, 9:17 PM
This revision is now accepted and ready to land.Fri, Feb 20, 9:17 PM
Closed by commit rGe1886559ea47: tcp: improve validation of received TCP over UDP packets (authored by tuexen). · Explain WhyFri, Feb 20, 9:24 PM
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rGe1886559ea47: tcp: improve validation of received TCP over UDP packets.
tuexen marked an inline comment as done.Fri, Feb 20, 9:30 PM
tuexen added inline comments.
sys/netinet/tcp_subr.c
623

Will put that in a cleanup I will make.

bms added a subscriber: bms.Sat, Feb 21, 12:23 PM
timo.voelker_fh-muenster.de added a comment.Sun, Feb 22, 10:53 AM

I agree on @pouria's comment.

A __predict_false makes sense in the IPv6 case as well.

bms added subscribers: rgrimes, gnn.Sun, Feb 22, 12:51 PM
In D55410#1267939, @timo.voelker_fh-muenster.de wrote:

I agree on @pouria's comment.

A __predict_false makes sense in the IPv6 case as well.

Had to do the same for SBR-ILNP for IPv6 vs ILNPv6 flows, in ip6_forward(), when deciding whether or not to call ilnp6_forward(), which currently exists only in the sup3r s3krt bms dSBR-ILNP branch. @rgrimes will probably not have to deal with this as it wasn't really a issue for hosts.

Currently busy spinning up on SRv6. The code archeaology of FreeBSD vs source routing is a story for another time. I see @gnn knows where some of the bodies are buried there.

tuexen marked an inline comment as done.Sun, Feb 22, 1:14 PM
In D55410#1267939, @timo.voelker_fh-muenster.de wrote:

I agree on @pouria's comment.

A __predict_false makes sense in the IPv6 case as well.

Done in D55415.

Revision Contents
Changeset List

PathSize
sys/
netinet/
22 lines

Diff 172345

View Options

sys/netinet/tcp_subr.c

Loading...