Page MenuHomeFreeBSD
Differential D55338

tcp: add support for TCP_RST_REASON_CODE socket option
Needs ReviewPublic
Actions

Authored by tuexen on Tue, Feb 17, 10:05 PM.
Tags
None
Referenced Files
F145666460: D55338.id172215.diff
Sun, Feb 22, 8:57 PM
F145652051: D55338.id172106.diff
Sun, Feb 22, 4:35 PM
F145630184: D55338.id172187.diff
Sun, Feb 22, 9:45 AM
Unknown Object (File)
Sun, Feb 22, 12:41 AM
Unknown Object (File)
Sat, Feb 21, 10:17 PM
Unknown Object (File)
Sat, Feb 21, 6:56 PM
Unknown Object (File)
Sat, Feb 21, 6:01 PM
Unknown Object (File)
Sat, Feb 21, 5:47 PM
View All 33 Files
Subscribers
imp
melifaro
pouria

Details

Reviewers
glebius
gnn
rrs
Group Reviewers
transport
Summary

This code is based on the upcoming version 15 of draft-boucadair-tcpm-rst-diagnostic-payload.
Right now, only the IPPROTO_TCP-level socket option with name TCP_RST_REASON_CODE is implemented.
It is planned to implement also the socket option with name `TCP_RST_REASON_CODE, but it is NOT planned to implement the socket option with name TCP_RST_REASON_DESC.

Test Plan
  • Use {F145514417} and {F145514426} in combination with {F145514432}.
  • Extend packetdrill to support these socket options and write tests.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

tuexen created this revision.Tue, Feb 17, 10:05 PM
Herald added a reviewer: gnn. · View Herald TranscriptTue, Feb 17, 10:05 PM
Herald added a reviewer: transport. · View Herald Transcript
Herald added subscribers: melifaro, imp. · View Herald Transcript
tuexen requested review of this revision.Tue, Feb 17, 10:05 PM
rrs accepted this revision.Wed, Feb 18, 2:22 PM
This revision is now accepted and ready to land.Wed, Feb 18, 2:22 PM
tuexen added a comment.Wed, Feb 18, 2:45 PM

This is work in progress. There will be some more changes.

rrs added a comment.Wed, Feb 18, 3:01 PM
In D55338#1265942, @tuexen wrote:

This is work in progress. There will be some more changes.

Thats fine.. nice to see the IETF catching TCP up to SCTP's abort codes :)

tuexen updated this revision to Diff 172154.Wed, Feb 18, 3:07 PM

Allow socket option processing on inps with the INP_DROPPED flag set only for getsockopt() of the IPPROTO_TCP-level socket option with name TCP_RST_REASON_CODE, as glebius suggested.

This revision now requires review to proceed.Wed, Feb 18, 3:07 PM
tuexen updated this revision to Diff 172187.Wed, Feb 18, 5:08 PM

Fix sender side stats counter and teach netstat how to print the stats counters added in this patch.

tuexen updated this revision to Diff 172204.Wed, Feb 18, 8:50 PM

Fix TCP over UDP tunneling.

tuexen updated this revision to Diff 172205.Wed, Feb 18, 9:23 PM

Fix checksum computation.

tuexen edited the test plan for this revision. (Show Details)Wed, Feb 18, 9:24 PM
tuexen updated this revision to Diff 172215.Thu, Feb 19, 10:30 AM

Improve inputs validation for UDP encapsulated TCP segments.

tuexen updated this revision to Diff 172340.Fri, Feb 20, 8:17 PM

Update names of structure and provide a way that setsocktion SO_LINGER is not required anymore.

tuexen updated this revision to Diff 172341.Fri, Feb 20, 8:20 PM

Minor cleanup.

tuexen edited the test plan for this revision. (Show Details)Fri, Feb 20, 8:21 PM
tuexen updated this revision to Diff 172367.Sat, Feb 21, 8:34 AM

Rebase and cleanup.

tuexen updated this revision to Diff 172368.Sat, Feb 21, 8:35 AM

With context.

pouria added a subscriber: pouria.Sat, Feb 21, 3:21 PM

Revision Contents
Changeset List

PathSize
sys/
netinet/
4 lines
4 lines
8 lines
9 lines
36 lines
tcp_stacks/
57 lines
61 lines
4 lines
7 lines
38 lines
5 lines
56 lines
20 lines
usr.bin/
netstat/
8 lines

Diff 172341

View Options

sys/netinet/in_kdtrace.h

Loading...
View Options

sys/netinet/in_kdtrace.c

Loading...
View Options

sys/netinet/tcp.h

Loading...
View Options

sys/netinet/tcp_input.c

Loading...
View Options

sys/netinet/tcp_output.c

Loading...
View Options

sys/netinet/tcp_stacks/bbr.c

Loading...
View Options

sys/netinet/tcp_stacks/rack.c

Loading...
View Options

sys/netinet/tcp_stacks/rack_bbr_common.h

Loading...
View Options

sys/netinet/tcp_stacks/rack_bbr_common.c

Loading...
View Options

sys/netinet/tcp_subr.c

Loading...
View Options

sys/netinet/tcp_syncache.c

Loading...
View Options

sys/netinet/tcp_usrreq.c

Loading...
View Options

sys/netinet/tcp_var.h

Loading...
View Options

usr.bin/netstat/inet.c

Loading...