multicast(4): Fix disabling multicast forwarding
ClosedPublic
Actions

Authored by pouria on Thu, Feb 12, 11:10 PM.

Details

Reviewers

markj
glebius

Group Reviewers

manpages
network

Commits

rG49ab036fc48a: multicast.4: Fix disabling multicast forwarding
rGf2c2e5b0bf9d: multicast.4: Fix disabling multicast forwarding

Summary

multicast(4) mistakenly stated that multicast
forwarding can be disabled with MRT_INIT by setting
its value to 0.
Fix by adding MRT_DONE and MRT6_DONE.

Test Plan

mandoc -Tlint

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pouria created this revision.Thu, Feb 12, 11:10 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptThu, Feb 12, 11:10 PM

pouria requested review of this revision.Thu, Feb 12, 11:10 PM

Harbormaster completed remote builds in B70651: Diff 171843.Thu, Feb 12, 11:10 PM

Thanks!

share/man/man4/multicast.4
149	I'd suggest a slightly different wording: `When applied to the multicast routing socket, the .Dv MRT_DONE and .Dv MRT6_DONE socket options disable multicast forwarding in the kernel:`
158	Closing the socket has the same effect, we could mention that here too.

Agree with markj. Nit: commit message should be "multicast.4: Fix disabling multicast forwarding". "multicast(4)" could refer to changing the logic of the driver, but "multicast.4" clearly refers only to the manual page.

Been spring-cleaning my cluster home directory, as I only regained access for the first time in nearly 10 years this morning UK time. This commit probably has some relevant history lessons.