sdt: Enable on 32-bit powerpc and powerpc64le
ClosedPublic
Actions

Authored by markj on Jan 21 2026, 5:13 PM.

Details

Reviewers

jhibbits
adrian
gnn

Commits

rG769bc6877399: sdt: Enable on 32-bit powerpc and powerpc64le
rG6e32e8d7d161: sdt: Enable on 32-bit powerpc and powerpc64le

Summary

The former because we expect it will work, and the latter because it was
omitted by mistake.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70044
Build 66927: arc lint + arc unit

Event Timeline

markj created this revision.Jan 21 2026, 5:13 PM

Herald added a reviewer: gnn. · View Herald TranscriptJan 21 2026, 5:13 PM

Herald added a subscriber: imp. · View Herald Transcript

markj requested review of this revision.Jan 21 2026, 5:13 PM

Harbormaster completed remote builds in B70044: Diff 170201.Jan 21 2026, 5:13 PM

works for me!

tested: power8 S822LC, powerNV (160 threads)

This revision is now accepted and ready to land.Jan 21 2026, 7:43 PM

Please MFC this to 15 and 14 as well.

Is either of you able to test 32-bit powerpc? Just something like dtrace -n 'sched:::on-cpu {stack();}' should be good enough. If not I'll try to test when I get a chance.

sigh, turns out we need to fix something in sdt_machdep.h first:

--------------------------------------------------------------
>>> stage 3.1: building everything
--------------------------------------------------------------
/home/adrian/work/freebsd/head/freebsd-src-ppc64/sys/powerpc/powerpc/sdt_machdep.c:41:16: error: format specifies type 'unsigned long' but the argument has type 'uintptr_t' (aka 'unsigned int') [-Werror,-Wformat]
   40 |             ("%s: invalid tracepoint %#lx -> %#lx",
      |                                      ~~~~
      |                                      %#x
   41 |             __func__, patchpoint, target));
      |                       ^~~~~~~~~~
/home/adrian/work/freebsd/head/freebsd-src-ppc64/sys/sys/kassert.h:146:17: note: expanded from macro 'KASSERT'
  146 |                 kassert_panic msg;

This happens when building powerpc;powerpc + GENERIC, but not powerpc:powerpc64 + GENERIC64