Page MenuHomeFreeBSD

sdt: Enable on 32-bit powerpc and powerpc64le
ClosedPublic

Authored by markj on Wed, Jan 21, 5:13 PM.
Tags
None
Referenced Files
F144870773: D54814.id170774.diff
Fri, Feb 13, 2:55 PM
Unknown Object (File)
Sun, Feb 8, 4:06 PM
Unknown Object (File)
Fri, Feb 6, 6:27 AM
Unknown Object (File)
Tue, Jan 27, 12:20 AM
Unknown Object (File)
Mon, Jan 26, 2:15 AM
Unknown Object (File)
Sun, Jan 25, 11:23 AM
Unknown Object (File)
Sun, Jan 25, 6:43 AM
Unknown Object (File)
Fri, Jan 23, 2:40 AM
Subscribers

Details

Summary

The former because we expect it will work, and the latter because it was
omitted by mistake.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Wed, Jan 21, 5:13 PM

works for me!

tested: power8 S822LC, powerNV (160 threads)

This revision is now accepted and ready to land.Wed, Jan 21, 7:43 PM

Please MFC this to 15 and 14 as well.

Is either of you able to test 32-bit powerpc? Just something like dtrace -n 'sched:::on-cpu {stack();}' should be good enough. If not I'll try to test when I get a chance.

sigh, turns out we need to fix something in sdt_machdep.h first:

--------------------------------------------------------------
>>> stage 3.1: building everything
--------------------------------------------------------------
/home/adrian/work/freebsd/head/freebsd-src-ppc64/sys/powerpc/powerpc/sdt_machdep.c:41:16: error: format specifies type 'unsigned long' but the argument has type 'uintptr_t' (aka 'unsigned int') [-Werror,-Wformat]
   40 |             ("%s: invalid tracepoint %#lx -> %#lx",
      |                                      ~~~~
      |                                      %#x
   41 |             __func__, patchpoint, target));
      |                       ^~~~~~~~~~
/home/adrian/work/freebsd/head/freebsd-src-ppc64/sys/sys/kassert.h:146:17: note: expanded from macro 'KASSERT'
  146 |                 kassert_panic msg;

This happens when building powerpc;powerpc + GENERIC, but not powerpc:powerpc64 + GENERIC64

Fix the build on 32-bit powerpc

This revision now requires review to proceed.Fri, Jan 30, 2:02 PM

sigh, turns out we need to fix something in sdt_machdep.h first:

Woops, I thought I had build-tested this...

This revision is now accepted and ready to land.Fri, Jan 30, 2:22 PM
This revision was automatically updated to reflect the committed changes.