Page MenuHomeFreeBSD
Differential D54652

bhyvectl: Generalize bhyve IPC code
Needs ReviewPublic
Actions

Authored by bnovkov on Sun, Jan 11, 1:33 PM.
Tags
None
Referenced Files
F144033314: D54652.diff
Tue, Feb 3, 4:22 PM
Unknown Object (File)
Fri, Jan 30, 3:18 PM
Unknown Object (File)
Sun, Jan 25, 5:04 AM
Unknown Object (File)
Sat, Jan 24, 7:13 PM
Unknown Object (File)
Tue, Jan 20, 1:18 PM
Unknown Object (File)
Fri, Jan 16, 4:32 PM
Unknown Object (File)
Thu, Jan 15, 8:32 PM
Unknown Object (File)
Thu, Jan 15, 7:23 AM
View All 14 Files
Subscribers
bcran
imp
rew
rgrimes

Details

Reviewers
None
Group Reviewers
bhyve
Summary

Move the nvlist-based bhyve IPC code into a separate function.
No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69801
Build 66684: arc lint + arc unit

Event Timeline

bnovkov created this revision.Sun, Jan 11, 1:33 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptSun, Jan 11, 1:33 PM
bnovkov requested review of this revision.Sun, Jan 11, 1:33 PM
Harbormaster completed remote builds in B69801: Diff 169472.Sun, Jan 11, 1:33 PM
bnovkov added a parent revision: D54651: bhyve/pci_emul.c: Add PCI hotplugging IPC commands.Sun, Jan 11, 1:33 PM
bnovkov added a child revision: D54653: bhyvectl: Add device hotplugging options.
rew added a subscriber: rew.Mon, Jan 12, 7:44 AM

if possible, it might be worth splitting the ipc changes outside of hot pluggable stack

think you can land the ipc changes without the hot plugging bits

usr.sbin/bhyvectl/bhyvectl.c
253

if you rename nvl to request and then see my suggestion for lines 278-285

278–285

could use nvlist_xfer() instead of nvlist_send() and nvlist_recv()

declare a nvlist_t *reply and then something like reply = nvlist_xfer(socket_fd, request, 0)

bnovkov updated this revision to Diff 169536.Mon, Jan 12, 6:57 PM
bnovkov marked 2 inline comments as done.

Address @rew 's comments.

usr.sbin/bhyvectl/bhyvectl.c
278–285

Thank you for the suggestion, nvlist_xfer makes things much simpler.

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyvectl/
24 lines

Diff 169472

View Options

usr.sbin/bhyvectl/bhyvectl.c

Loading...