Indentation of continuation lines for arguments is not as per style(9) (4 spaces, not a 8-space TAB), but consistent with some other smp_rendezvous_*() functions, so I'm fine with that (and these could all be fixed in a subsequent commit).

This revision is now accepted and ready to land.Jan 6 2026, 9:01 AM

aokblast added reviewers: markj, lwhsu.Jan 10 2026, 8:39 AM

Looks ok, but I'd use int in the function signature.

sys/kern/subr_smp.c
628	The cpuid type is usually int (see ipi_cpu() for instance) or u_int, we should follow that convention instead of using a fixed-width type.

Closed by commit rG5b61ef94d65a: smp: add smp_rendezvous_cpu helper function (authored by aokblast). · Explain WhyJan 16 2026, 2:39 PM

This revision was automatically updated to reflect the committed changes.

aokblast added a commit: rG5b61ef94d65a: smp: add smp_rendezvous_cpu helper function.

In D54551#1248714, @markj wrote:

Looks ok, but I'd use int in the function signature.

I use u_int since pcpu->cpuid is u_int.

Revision Contents
Changeset List

Path

Size

sys/

kern/

subr_smp.c

13 lines

sys/

smp.h

7 lines

Diff 169153

View Options

sys/kern/subr_smp.c

View Options

smp: add smp_rendezvous_cpu helper functionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 169153

sys/kern/subr_smp.c

sys/sys/smp.h

smp: add smp_rendezvous_cpu helper function
ClosedPublic
Actions

Revision Contents
Changeset List