libc/stdc_has_single_bit.c: fix gcc warning (-Wparentheses)
ClosedPublic
Actions

Authored by fuz on Dec 3 2025, 6:41 PM.

Details

Reviewers

des
adrian
jrtc27
markj

Commits

rGfff2795baf1a: libc/stdc_has_single_bit.c: fix gcc warning (-Wparentheses)
rG3d71ce92eae9: libc/stdc_has_single_bit.c: fix gcc warning (-Wparentheses)

Summary

gcc14 is concerned that the operator precedence between - and & might
be confusing. Throw in some redundant parentheses to make it shut up.
The LLVM build was fine before this change, too.

Reported by: Martin Filla <freebsd@sysctl.cz>
MFC after: 1 month

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 69020
Build 65903: arc lint + arc unit

Event Timeline

fuz created this revision.Dec 3 2025, 6:41 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 3 2025, 6:41 PM

fuz requested review of this revision.Dec 3 2025, 6:41 PM

Harbormaster completed remote builds in B69020: Diff 167488.Dec 3 2025, 6:41 PM

fuz added a parent revision: D53657: libc: implement C23 <stdbit.h> functions.Dec 3 2025, 6:41 PM

Approved

This revision was not accepted when it landed; it landed in state Needs Review.Dec 3 2025, 8:02 PM

Closed by commit rG3d71ce92eae9: libc/stdc_has_single_bit.c: fix gcc warning (-Wparentheses) (authored by fuz). · Explain Why

This revision was automatically updated to reflect the committed changes.

fuz added a commit: rG3d71ce92eae9: libc/stdc_has_single_bit.c: fix gcc warning (-Wparentheses).

fuz added a commit: rGfff2795baf1a: libc/stdc_has_single_bit.c: fix gcc warning (-Wparentheses).Thu, Jan 1, 10:22 PM

Revision Contents
Changeset List

Path

Size

lib/

libc/

stdbit/

stdc_has_single_bit.c

10 lines

Diff 167488

View Options

lib/libc/stdbit/stdc_has_single_bit.c

libc/stdc_has_single_bit.c: fix gcc warning (-Wparentheses)ClosedPublicActions