nvme: Improve error message for invalid format value
Needs ReviewPublic
Actions

Authored by imp on Jul 17 2025, 7:52 PM.

Tags

None

Referenced Files

	F137461833: D51393.diff
	Sun, Nov 23, 5:02 PM

	Unknown Object (File)
	Sat, Nov 22, 1:58 PM

	Unknown Object (File)
	Sat, Nov 22, 4:52 AM

	Unknown Object (File)
	Mon, Nov 17, 1:23 AM

	Unknown Object (File)
	Fri, Nov 14, 11:00 PM

	Unknown Object (File)
	Fri, Nov 14, 8:14 PM

	Unknown Object (File)
	Fri, Nov 14, 8:13 PM

	Unknown Object (File)
	Fri, Nov 14, 8:09 PM

View All 29 Files

Subscribers

dab

Details

Reviewers

jhb
mav
chs
chuck
ken

Summary

Improve the wording of the invalid namespace value. Reword the comment
and move a line of code to the block it logically belongs to.

No functional changes intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68661
Build 65544: arc lint + arc unit

Event Timeline

imp created this revision.Jul 17 2025, 7:52 PM

Herald added a subscriber: dab. · View Herald TranscriptJul 17 2025, 7:52 PM

imp requested review of this revision.Jul 17 2025, 7:52 PM

imp added a parent revision: D51392: nvme: Remove consumer functionality.

imp added a child revision: D51394: nvme: Split the namespace init into resetting / !reestting case.

Harbormaster completed remote builds in B65539: Diff 158700.Jul 17 2025, 7:52 PM

Update per review, add missing change

Harbormaster completed remote builds in B68661: Diff 166482.Fri, Nov 14, 7:55 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvme/

nvme_ns.c

12 lines

Diff 166482

View Options

nvme: Improve error message for invalid format valueNeeds ReviewPublicActions