Page MenuHomeFreeBSD
Differential D53739

Update ip_ecn to use C standard types
ClosedPublic
Actions

Authored by p.mousavizadeh_protonmail.com on Thu, Nov 13, 4:29 PM.
Tags
None
Referenced Files
F137159774: D53739.diff
Fri, Nov 21, 7:52 AM
Unknown Object (File)
Tue, Nov 18, 10:02 PM
Unknown Object (File)
Mon, Nov 17, 8:09 PM
Unknown Object (File)
Fri, Nov 14, 4:08 AM
Unknown Object (File)
Fri, Nov 14, 3:08 AM
Unknown Object (File)
Fri, Nov 14, 2:41 AM
Unknown Object (File)
Fri, Nov 14, 1:09 AM
Unknown Object (File)
Fri, Nov 14, 12:49 AM
View All 11 Files
Subscribers
ae
imp
melifaro
zlei

Details

Reviewers
glebius
zlei
rscheff
tuexen
Group Reviewers
network
transport
Commits
rGf2582653a429: ip: use standard C types for ECN helper functions
Summary

Update ip_ecn to use C standard types. to be stacked with D53516

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 68607
Build 65490: arc lint + arc unit

Event Timeline

p.mousavizadeh_protonmail.com created this revision.Thu, Nov 13, 4:29 PM
Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptThu, Nov 13, 4:29 PM
p.mousavizadeh_protonmail.com requested review of this revision.Thu, Nov 13, 4:29 PM
Harbormaster completed remote builds in B68605: Diff 166372.Thu, Nov 13, 4:29 PM
p.mousavizadeh_protonmail.com edited the summary of this revision. (Show Details)Thu, Nov 13, 4:31 PM
p.mousavizadeh_protonmail.com mentioned this in D53517: Add ecn(9) manual.Thu, Nov 13, 4:43 PM
p.mousavizadeh_protonmail.com updated this revision to Diff 166374.Thu, Nov 13, 4:54 PM

to be stacked with new D53516

Harbormaster completed remote builds in B68607: Diff 166374.Thu, Nov 13, 4:54 PM
p.mousavizadeh_protonmail.com added a child revision: D53517: Add ecn(9) manual.Thu, Nov 13, 5:01 PM
zlei added a subscriber: zlei.Fri, Nov 14, 2:52 AM

I have no objections to do this. Well new code should prefer the standard types, but the existing code can be left as is.

zlei accepted this revision as: zlei.Fri, Nov 14, 2:52 AM
This revision is now accepted and ready to land.Fri, Nov 14, 2:52 AM
rscheff accepted this revision.Fri, Nov 14, 8:20 AM
p.mousavizadeh_protonmail.com added a comment.Sat, Nov 15, 11:38 AM

Thank you @rscheff and @zlei
I'm not a committer. Could you please commit this or you want to wait for D53516?

tuexen accepted this revision.Mon, Nov 17, 8:05 PM
tuexen added a comment.Mon, Nov 17, 8:15 PM
In D53739#1227758, @p.mousavizadeh_protonmail.com wrote:

Thank you @rscheff and @zlei
I'm not a committer. Could you please commit this or you want to wait for D53516?

Can you please base this patch on main such that it cleanly applies. Then I will commit it first.

p.mousavizadeh_protonmail.com updated this revision to Diff 166734.Wed, Nov 19, 7:47 AM

@tuexen done.

This revision now requires review to proceed.Wed, Nov 19, 7:47 AM
Harbormaster completed remote builds in B68721: Diff 166734.Wed, Nov 19, 7:47 AM
tuexen accepted this revision.Fri, Nov 21, 7:54 AM
This revision is now accepted and ready to land.Fri, Nov 21, 7:54 AM
Closed by commit rGf2582653a429: ip: use standard C types for ECN helper functions (authored by p.mousavizadeh_protonmail.com, committed by tuexen). · Explain WhyFri, Nov 21, 8:02 AM
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rGf2582653a429: ip: use standard C types for ECN helper functions.

Revision Contents
Changeset List

PathSize
sys/
netinet/
4 lines
16 lines
netinet6/
4 lines

Diff 166374

View Options

sys/netinet/ip_ecn.h

Loading...
View Options

sys/netinet/ip_ecn.c

Loading...
View Options

sys/netinet6/ip6_ecn.h

Loading...