Page MenuHomeFreeBSD
Differential D53739

Update ip_ecn to use C standard types
ClosedPublic
Actions

Authored by pouria on Nov 13 2025, 4:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 22, 2:35 PM
Unknown Object (File)
Sun, Mar 22, 10:22 AM
Unknown Object (File)
Thu, Mar 19, 2:18 AM
Unknown Object (File)
Tue, Mar 17, 1:21 PM
Unknown Object (File)
Tue, Mar 17, 12:52 PM
Unknown Object (File)
Sat, Mar 14, 5:17 PM
Unknown Object (File)
Thu, Mar 12, 1:14 AM
Unknown Object (File)
Tue, Mar 10, 1:11 AM
View All 55 Files
Subscribers
ae
imp
melifaro
zlei

Details

Reviewers
glebius
zlei
rscheff
tuexen
Group Reviewers
network
transport
Commits
rGf2582653a429: ip: use standard C types for ECN helper functions
Summary

Update ip_ecn to use C standard types. to be stacked with D53516

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 68605
Build 65488: arc lint + arc unit

Event Timeline

pouria created this revision.Nov 13 2025, 4:29 PM
Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptNov 13 2025, 4:29 PM
pouria requested review of this revision.Nov 13 2025, 4:29 PM
Harbormaster completed remote builds in B68605: Diff 166372.Nov 13 2025, 4:29 PM
pouria edited the summary of this revision. (Show Details)Nov 13 2025, 4:31 PM
pouria mentioned this in D53517: Add ecn(9) manual.Nov 13 2025, 4:43 PM
pouria updated this revision to Diff 166374.Nov 13 2025, 4:54 PM

to be stacked with new D53516

Harbormaster completed remote builds in B68607: Diff 166374.Nov 13 2025, 4:54 PM
pouria added a child revision: D53517: Add ecn(9) manual.Nov 13 2025, 5:01 PM
zlei added a subscriber: zlei.Nov 14 2025, 2:52 AM

I have no objections to do this. Well new code should prefer the standard types, but the existing code can be left as is.

zlei accepted this revision as: zlei.Nov 14 2025, 2:52 AM
This revision is now accepted and ready to land.Nov 14 2025, 2:52 AM
rscheff accepted this revision.Nov 14 2025, 8:20 AM
pouria added a comment.Nov 15 2025, 11:38 AM

Thank you @rscheff and @zlei
I'm not a committer. Could you please commit this or you want to wait for D53516?

tuexen accepted this revision.Nov 17 2025, 8:05 PM
tuexen added a comment.Nov 17 2025, 8:15 PM
In D53739#1227758, @p.mousavizadeh_protonmail.com wrote:

Thank you @rscheff and @zlei
I'm not a committer. Could you please commit this or you want to wait for D53516?

Can you please base this patch on main such that it cleanly applies. Then I will commit it first.

pouria updated this revision to Diff 166734.Nov 19 2025, 7:47 AM

@tuexen done.

This revision now requires review to proceed.Nov 19 2025, 7:47 AM
Harbormaster completed remote builds in B68721: Diff 166734.Nov 19 2025, 7:47 AM
tuexen accepted this revision.Nov 21 2025, 7:54 AM
This revision is now accepted and ready to land.Nov 21 2025, 7:54 AM
Closed by commit rGf2582653a429: ip: use standard C types for ECN helper functions (authored by pouria, committed by tuexen). · Explain WhyNov 21 2025, 8:02 AM
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rGf2582653a429: ip: use standard C types for ECN helper functions.

Revision Contents
Changeset List

PathSize
sys/
netinet/
4 lines
16 lines
netinet6/
4 lines

Diff 166372

View Options

sys/netinet/ip_ecn.h

Loading...
View Options

sys/netinet/ip_ecn.c

Loading...
View Options

sys/netinet6/ip6_ecn.h

Loading...