rc: dmesg: Allow file and umask to be configurable
ClosedPublic
Actions

Authored by jlduran on Oct 17 2025, 4:39 PM.

Details

Reviewers

Group Reviewers

Commits

rG549cba3c9d1e: rc: dmesg: Allow umask to be configurable
rGd8ddea0d4b0a: rc: dmesg: Allow umask to be configurable
rGfa2e886206f4: rc: dmesg: Allow umask to be configurable
rGedadbc6ee955: rc: dmesg: Allow umask to be configurable

Summary

Allow file, and umask to be configurable.

Being able to set the umask via an rc variable is useful when setting:

security.bsd.unprivileged_read_msgbuf=0

As it allows a user to configure:

dmesg_umask="066"

Without modifying the rc script, and preventing the contents of the
$dmesg_file (/var/run/dmesg.boot) from being publicly readable.

PR: 272552

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 67873
Build 64756: arc lint + arc unit

Event Timeline

jlduran created this revision.Oct 17 2025, 4:39 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 17 2025, 4:39 PM

jlduran requested review of this revision.Oct 17 2025, 4:39 PM

Harbormaster completed remote builds in B67873: Diff 164426.Oct 17 2025, 4:39 PM

jlduran added a parent revision: D53168: rc.conf: Fix typo interferring -> interfering.Oct 17 2025, 4:39 PM

jlduran added a child revision: D53170: bsdinstall: Fix typos.

jlduran added a reviewer: rc.Oct 17 2025, 4:43 PM

jlduran added inline comments.

libexec/rc/rc.d/dmesg
15	I can leave this part of the patch intact, without the user being able to change the dmesg_file via rc.conf. My main focus is on setting the umask before creating the file (with an rc variable).

The umask part looks fine.
About the dmesg_file part: from a technical point of view it is ok.,From a feature point of view, if it is not necessary, don't change it (I can't remember to have seen someone to have asked in the last 20 years about having it in another location).

This revision is now accepted and ready to land.Oct 18 2025, 2:00 PM

In D53169#1215059, @netchild wrote:

The umask part looks fine.
About the dmesg_file part: from a technical point of view it is ok.,From a feature point of view, if it is not necessary, don't change it (I can't remember to have seen someone to have asked in the last 20 years about having it in another location).

Thank you, good advice! Will do so when committing.

Closed by commit rGedadbc6ee955: rc: dmesg: Allow umask to be configurable (authored by jlduran). · Explain WhyOct 18 2025, 5:15 PM

This revision was automatically updated to reflect the committed changes.

jlduran added a commit: rGedadbc6ee955: rc: dmesg: Allow umask to be configurable.

jlduran added a commit: rGfa2e886206f4: rc: dmesg: Allow umask to be configurable.Oct 20 2025, 4:09 PM

jlduran added a commit: rGd8ddea0d4b0a: rc: dmesg: Allow umask to be configurable.

jlduran added a commit: rG549cba3c9d1e: rc: dmesg: Allow umask to be configurable.