Page MenuHomeFreeBSD
Differential D52862

thunderbolt: Pink Sardine support
Needs ReviewPublic
Actions

Authored by obiwac on Oct 2 2025, 3:50 PM.
Tags
None
Referenced Files
F151945330: D52862.id.diff
Sat, Apr 11, 4:39 PM
F151901669: D52862.id.diff
Sat, Apr 11, 10:57 AM
Unknown Object (File)
Fri, Apr 10, 9:31 PM
Unknown Object (File)
Wed, Apr 8, 11:24 PM
Unknown Object (File)
Wed, Apr 8, 11:11 PM
Unknown Object (File)
Sat, Apr 4, 2:21 PM
Unknown Object (File)
Mon, Mar 30, 2:48 AM
Unknown Object (File)
Sun, Mar 29, 12:38 PM
View All 55 Files
Subscribers
None

Details

Reviewers
emaste
imp
jhb
mohammad_fbsdphab_thelightbird.com
Summary

Support Pink Sardine NHIs. The only practical change this requires is
clearing the ISR0 register.

Also add IDs for the Pink Sardine PCI-PCI bridge to tb_pcib.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 67493
Build 64376: arc lint + arc unit

Event Timeline

obiwac requested review of this revision.Oct 2 2025, 3:50 PM
obiwac created this revision.
Harbormaster completed remote builds in B67493: Diff 163354.Oct 2 2025, 3:50 PM
obiwac added a parent revision: D52861: thunderbolt: Support generic USB4 NHIs.Oct 2 2025, 3:51 PM
obiwac added inline comments.
sys/dev/thunderbolt/nhi.c
1057

See comment in D49451 about specifying where this reference is from. Though maybe I should do a separate commit with this change to all existing references in the USB4 code.

obiwac mentioned this in D49451: USB4 Pink Sardine controller support.Oct 2 2025, 3:53 PM
emaste added inline comments.Oct 2 2025, 3:54 PM
sys/dev/thunderbolt/nhi.c
1057

Yeah, I'd just go ahead and make that change for any existing references first.

obiwac updated this revision to Diff 172660.Feb 25 2026, 9:24 AM

Rebase

Harbormaster completed remote builds in B70984: Diff 172660.Feb 25 2026, 9:24 AM
obiwac mentioned this in D52861: thunderbolt: Support generic USB4 NHIs.Mar 4 2026, 1:04 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
thunderbolt/
14 lines
4 lines
2 lines
4 lines

Diff 163354

View Options

sys/dev/thunderbolt/nhi.c

Loading...
View Options

sys/dev/thunderbolt/router.c

Loading...
View Options

sys/dev/thunderbolt/tb_pcib.h

Loading...
View Options

sys/dev/thunderbolt/tb_pcib.c

Loading...