This will allow the VM image build scripts to use the same repository
config file for installing base system packages at build time.
Sponsored by: The FreeBSD Foundation
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 67313 Build 64196: arc lint + arc unit
Event Timeline
Comment Actions
Looks good but I'd like to avoid having the literal worldstage in two different places if we can
| release/Makefile | ||
|---|---|---|
| 193 | Can we pick this up from WSTAGEDIR somehow? | |
| release/Makefile | ||
|---|---|---|
| 193 | I tried to find a way to do this using e.g. make -C ${WORLDDIR} -V WSTAGEDIR but wasn't able to figure out how to make it work, I never found a way to get make to print WSTAGEDIR with -V. Perhaps there's a gap in my understanding of how make/-V works though, any tips on how I might achieve this? | |
| release/Makefile | ||
|---|---|---|
| 193 | Kind of gross but: $ make -f Makefile.inc1 TARGET=amd64 TARGET_ARCH=amd64 -V WSTAGEDIR /usr/obj/home/emaste/src/freebsd-git/stable/14/amd64.amd64/worldstage assuming you have the target variables available and can do TARGET=$TARGET TARGET_ARCH=$TARGET_ARCH | |
| release/Makefile | ||
|---|---|---|
| 193 | Thanks Ed, I didn't think to use -f Makefile.inc1 for some reason. | |
| release/Makefile | ||
|---|---|---|
| 193 | No worries, it's not intuitive. I've just seen that in some Makefile machinery before. | |
| release/Makefile | ||
|---|---|---|
| 196–200 | Oh wait, this pkgbase-repo target shouldn't be deleted, it's still necessary. | |