Page MenuHomeFreeBSD

release: create pkgbase repo config from Makefile
ClosedPublic

Authored by ifreund_freebsdfoundation.org on Jul 24 2025, 8:46 AM.
Referenced Files
Unknown Object (File)
Fri, Oct 17, 1:53 PM
Unknown Object (File)
Fri, Oct 17, 1:07 PM
Unknown Object (File)
Thu, Oct 16, 4:00 PM
Unknown Object (File)
Wed, Oct 15, 4:59 AM
Unknown Object (File)
Thu, Oct 9, 3:04 PM
Unknown Object (File)
Thu, Oct 9, 3:04 PM
Unknown Object (File)
Thu, Oct 9, 3:03 PM
Unknown Object (File)
Thu, Oct 9, 3:03 PM
Subscribers

Details

Summary

This will allow the VM image build scripts to use the same repository
config file for installing base system packages at build time.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65645
Build 62528: arc lint + arc unit

Event Timeline

Looks good but I'd like to avoid having the literal worldstage in two different places if we can

release/Makefile
191

Can we pick this up from WSTAGEDIR somehow?

release/Makefile
191

I tried to find a way to do this using e.g. make -C ${WORLDDIR} -V WSTAGEDIR but wasn't able to figure out how to make it work, I never found a way to get make to print WSTAGEDIR with -V. Perhaps there's a gap in my understanding of how make/-V works though, any tips on how I might achieve this?

release/Makefile
191

Kind of gross but:

$ make -f Makefile.inc1 TARGET=amd64 TARGET_ARCH=amd64 -V WSTAGEDIR
/usr/obj/home/emaste/src/freebsd-git/stable/14/amd64.amd64/worldstage

assuming you have the target variables available and can do TARGET=$TARGET TARGET_ARCH=$TARGET_ARCH

release/Makefile
191

Thanks Ed, I didn't think to use -f Makefile.inc1 for some reason.

release/Makefile
191

No worries, it's not intuitive. I've just seen that in some Makefile machinery before.

This revision is now accepted and ready to land.Thu, Sep 25, 9:11 AM
emaste edited reviewers, added: ifreund_freebsdfoundation.org; removed: emaste.
This revision now requires review to proceed.Thu, Sep 25, 9:23 AM
This revision is now accepted and ready to land.Thu, Sep 25, 9:42 AM
ifreund_freebsdfoundation.org added inline comments.
release/Makefile
194–196

Oh wait, this pkgbase-repo target shouldn't be deleted, it's still necessary.

This revision now requires changes to proceed.Thu, Sep 25, 9:46 AM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, Sep 25, 12:36 PM
This revision was automatically updated to reflect the committed changes.