kern/kern_thread.c: improve assert in thread_single_end()
ClosedPublic
Actions

Authored by kib on Sat, Aug 30, 2:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Sep 4, 9:00 PM

	Unknown Object (File)
	Thu, Sep 4, 8:46 AM

	Unknown Object (File)
	Wed, Sep 3, 9:21 PM

	Unknown Object (File)
	Sun, Aug 31, 6:43 AM

	Unknown Object (File)
	Sun, Aug 31, 3:48 AM

	Unknown Object (File)
	Sun, Aug 31, 1:43 AM

	Unknown Object (File)
	Sun, Aug 31, 1:19 AM

	Unknown Object (File)
	Sun, Aug 31, 12:02 AM

Subscribers

Details

Reviewers

markj

Commits

rG8321d0da2ce2: kern/kern_thread.c: improve assert in thread_single_end()

Summary

The process might be stopped, which is handled by the loop that
unsuspends threads. But the condition is not tolerated in the assert,
which insists that all threads must be unsuspended always.

Reported and tested by: pho

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Sat, Aug 30, 2:45 PM

Herald added subscribers: olce, imp. · View Herald TranscriptSat, Aug 30, 2:45 PM

kib requested review of this revision.Sat, Aug 30, 2:45 PM

markj accepted this revision.Sat, Aug 30, 3:06 PM

This revision is now accepted and ready to land.Sat, Aug 30, 3:06 PM

Closed by commit rG8321d0da2ce2: kern/kern_thread.c: improve assert in thread_single_end() (authored by kib). · Explain WhySat, Aug 30, 3:07 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG8321d0da2ce2: kern/kern_thread.c: improve assert in thread_single_end().

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_thread.c

6 lines

Diff 161267

View Options

kern/kern_thread.c: improve assert in thread_single_end()ClosedPublicActions